Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MetaDeck to 3.0.0 #700

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

KP2048
Copy link
Contributor

@KP2048 KP2048 commented Sep 18, 2024

MetaDeck

Updated to decky v3, and fixed a lot of the long standing issues with the plugin.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@KP2048 KP2048 requested a review from a team as a code owner September 18, 2024 23:42
@TrainDoctor TrainDoctor requested a review from a team September 20, 2024 16:45
TrainDoctor
TrainDoctor previously approved these changes Sep 20, 2024
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review checks out. Good for testing store.

PartyWumpus
PartyWumpus previously approved these changes Oct 11, 2024
Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes after rewrite also look good

@KP2048
Copy link
Contributor Author

KP2048 commented Oct 20, 2024

@TrainDoctor can this get merged, or at least testing store?

@EMERALD0874 EMERALD0874 dismissed stale reviews from PartyWumpus and TrainDoctor October 20, 2024 19:35

Stale, MetaDeck has been updated since

Copy link
Member

@EMERALD0874 EMERALD0874 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved and sent to testing store

@KP2048
Copy link
Contributor Author

KP2048 commented Oct 20, 2024

Thanks!

@AAGaming00
Copy link
Member

btw this fails if the settings.json doesn't exist lol

@AAGaming00
Copy link
Member

still getting python errors even after making one. will get logs when i can

@KP2048
Copy link
Contributor Author

KP2048 commented Oct 23, 2024

Will fix and push a new version in a bit, need to fix my Hyprland setup

@KP2048 KP2048 reopened this Oct 31, 2024
@KP2048
Copy link
Contributor Author

KP2048 commented Oct 31, 2024

@AAGaming00 can you check and verify it works now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

5 participants