Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Audio Loader to 1.6.0 #696

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

EMERALD0874
Copy link
Member

@EMERALD0874 EMERALD0874 commented Sep 14, 2024

Audio Loader

Audio Loader is a tool for changing existing UI sounds and adding music while navigating Steam.

Unfortunately, due to recent breakages including one caused by Decky now running in desktop mode, we do not have the time or knowledge to solve bugs with the music part of Audio Loader. We have decided to make it a legacy feature until it is fixed, requiring users to check a box saying they acknowledge bugs may not be fixed and to use our GitHub for support.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

  • Tested on SteamOS Preview Update Channel.

@suchmememanyskill
Copy link
Contributor

@EMERALD0874 tested on steam deck oled, under the steam preview branch. Works as expected.

I do have 2 oddities to report. First, there's no header after enabling legacy features. A new unlabeled section pops up. This may be confusing to some users.

Second, the store still shows music submissions. You can download music packs while legacy features is disabled.

@EMERALD0874
Copy link
Member Author

@suchmememanyskill

  1. The reason there's no label is it seemed odd to me to have "Legacy Features" listed right below the enable toggle. I think the separation is clear enough given it falls beneath the toggle and only shows up when the relevant feature set is enabled, but I can change that if necessary.
  2. Managing music packs doesn't require legacy features to be enabled as otherwise users would have to go to desktop mode to modify their downloaded packs if they couldn't figure out that they had to enable the setting. I also don't want to create a precedent that legacy features require overriding the default store view, as I think it could get messy.

@suchmememanyskill
Copy link
Contributor

  1. I meant more a label of 'music', but fair enough.
  2. Fair, i forgot this isn't cssloader and the management and store screen are the same

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Off to testing.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EMERALD0874
Copy link
Member Author

Plugin fails to build in CI: https://github.com/SteamDeckHomebrew/decky-plugin-database/actions/runs/10864252954/job/30149318978

@TrainDoctor It looks like it worked here unless I'm missing something. This was build 2530 and you linked build 2529 (before I made a fix for the PNPM issue). https://github.com/SteamDeckHomebrew/decky-plugin-database/actions/runs/10864321414/job/30149465108

@TrainDoctor TrainDoctor self-requested a review October 13, 2024 18:34
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin changes are good to go. Off to testing for real 😅

@TrainDoctor TrainDoctor requested a review from a team October 13, 2024 18:35
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on SteamOS Stable, Beta and Preview Update Channel.
Works perfeclty fine.

Other Installed Plugins:
Storage CLeanner
Powertools
Moondeck
CSS Loader
Audio Loader
Tabmaster
Quick Launch
CHeatdeck
Steamgriddb
Game Theme Music
Autoflatpacks
Decky Terminal
Radiyo
Deckyfileserver
Animation Changer
Web Browser
Protondb Badges

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testers approve, good for production.

@TrainDoctor TrainDoctor merged commit a8e6a1e into SteamDeckHomebrew:main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants