Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ControllerTools to v1.2.2 #647

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jfernandez
Copy link
Contributor

@jfernandez jfernandez commented Jun 13, 2024

ControllerTools

Update ControllerTools to v1.2.2 and change the submodule to point to the new repository. The alphamercury repository is no longer maintained. You can verify this by going to the old url [1] and verifying that it redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin use the global DFL to address an error [3] in the UI after the Steam Deck client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

Several users tested this new build in this Issue and verified it works: jfernandez/ControllerTools#43

  • Tested on SteamOS Stable/Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

@jfernandez jfernandez requested a review from a team as a code owner June 13, 2024 02:18
Update ControllerTools to v1.2.2 and change the submodule to point to
the new repository. The alphamercury repository is no longer maintained.
You can verify this by going to the old url [1] and verifying that it
redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin
use the global DFL to address an error [3] in the UI after the Steam Deck
client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Signed-off-by: Jose Fernandez <[email protected]>
Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but you need to update the pnpm lockfile to pnpm 9.0.5, it has been recently updated, in order to build it correctly. Then looks fine for me for testing it :)

@jfernandez
Copy link
Contributor Author

@RodoMa92 I did update the pnpm lockfile, but I used the latest pnpm (9.2): jfernandez/ControllerTools@0be62f5

Do I need to use 9.05? I assumed any of the 9.* versions should work.

@Nottinghster
Copy link

Any news?

@RodoMa92
Copy link
Contributor

RodoMa92 commented Jun 21, 2024

@RodoMa92 I did update the pnpm lockfile, but I used the latest pnpm (9.2): jfernandez/ControllerTools@0be62f5

Do I need to use 9.05? I assumed any of the 9.* versions should work.

Sorry for the delay,

Yeah, the CI was still claiming pnpm 8.5.1 and I was confused initially, turns out I forgot to update the builder docker image with the actual updated pnpm version. I might just go and update them both again to the latest one for now, to avoid confusion.

Marco

@RodoMa92
Copy link
Contributor

RodoMa92 commented Jun 21, 2024

As soon as #652 lands, this should go through fine now. Sorry again for the mistake on my part. If you want to land it sooner, tho, using a closer version to 8.5.1 should make it go through fine.

@Nottinghster
Copy link

As soon as #652 lands, this should go through fine now. Sorry again for the mistake on my part. If you want to land it sooner, tho, using a closer version to 8.5.1 should make it go through fine.

News ??

@michaljuris
Copy link

michaljuris commented Jun 27, 2024

#652 seems to be still waiting for the review from somebody from SteamDeckHomebrew/loader-team ...

@RodoMa92 anyway to expedite that? ;)

@Nottinghster
Copy link

Again problem with pnpm ???

@michaljuris
Copy link

Again problem with pnpm ???

Still waiting for this: #652
But it is approved now so @RodoMa92 can merge it now.

@RodoMa92
Copy link
Contributor

Sadly now that I've merged #652 (Completely forgot), I can't rerun the workflow since it seems to cap it to 30 days since the initial PR. Not sure if anyone from @SteamDeckHomebrew/loader-team can help here or if it's easier just to reopen the PR itself :S

@RodoMa92 RodoMa92 merged commit b3bc102 into SteamDeckHomebrew:main Jul 16, 2024
1 of 2 checks passed
@RodoMa92
Copy link
Contributor

Easier to just merge and test it out this way. It is still completely broken anyway now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants