-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ControllerTools to v1.2.2 #647
Update ControllerTools to v1.2.2 #647
Conversation
Update ControllerTools to v1.2.2 and change the submodule to point to the new repository. The alphamercury repository is no longer maintained. You can verify this by going to the old url [1] and verifying that it redirects to the new url [2]. This new version pulls in the latest dependencies and makes the plugin use the global DFL to address an error [3] in the UI after the Steam Deck client update. [1] https://github.com/alphamercury/ControllerTools [2] https://github.com/jfernandez/ControllerTools [3] jfernandez/ControllerTools#43 Signed-off-by: Jose Fernandez <[email protected]>
cc8c582
to
656b61c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, but you need to update the pnpm lockfile to pnpm 9.0.5, it has been recently updated, in order to build it correctly. Then looks fine for me for testing it :)
@RodoMa92 I did update the pnpm lockfile, but I used the latest pnpm (9.2): jfernandez/ControllerTools@0be62f5 Do I need to use 9.05? I assumed any of the 9.* versions should work. |
Any news? |
Sorry for the delay, Yeah, the CI was still claiming pnpm 8.5.1 and I was confused initially, turns out I forgot to update the builder docker image with the actual updated pnpm version. I might just go and update them both again to the latest one for now, to avoid confusion. Marco |
As soon as #652 lands, this should go through fine now. Sorry again for the mistake on my part. If you want to land it sooner, tho, using a closer version to 8.5.1 should make it go through fine. |
News ?? |
Again problem with pnpm ??? |
Sadly now that I've merged #652 (Completely forgot), I can't rerun the workflow since it seems to cap it to 30 days since the initial PR. Not sure if anyone from @SteamDeckHomebrew/loader-team can help here or if it's easier just to reopen the PR itself :S |
Easier to just merge and test it out this way. It is still completely broken anyway now. |
ControllerTools
Update ControllerTools to v1.2.2 and change the submodule to point to the new repository. The alphamercury repository is no longer maintained. You can verify this by going to the old url [1] and verifying that it redirects to the new url [2].
This new version pulls in the latest dependencies and makes the plugin use the global DFL to address an error [3] in the UI after the Steam Deck client update.
[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
Several users tested this new build in this Issue and verified it works: jfernandez/ControllerTools#43