-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decky-spy plugin #621
Add decky-spy plugin #621
Conversation
Any update about this PR? |
@Seraphli apologies, I suspect the workflow failed and then the PR was passed over due to having to prioritize PRs without failed builds. It looks like the workflow worked this go around and the plugin should now be on the testing store. |
Thanks. BTW, can anyone fix the installer? SteamDeckHomebrew/decky-installer#16 |
@TrainDoctor I test the plugin in test store, but I find the plugin is not built properly. May I ask how the plugin is built? So I can fix the process. |
All python requirements must be bundled into the defaults folder in order to work properly. Use the CLI builder to see what the plugin will build as on the store. |
@Seraphli your recent commit bundles our CLI binary into your defaults folder which will not accomplish anything other than shipping an unnecessary binary with a broken plugin. You need to take any python libraries into a py_modules folder and place that folder in the defaults folder where the plugin can grab the libraries directly from py_modules etc. Please look towards other plugins that use python libraries for examples of how to do this properly. |
I have moved the python libraries into py_modules |
Please understand that these will not be deployed with your plugin unless you move py_modules into the defaults folder. |
I follow this repo, https://github.com/steam3d/MagicPodsDecky |
Ah, I think I missed a change in our CI/CD at some point. Just checked the built plugin and it seems to be layed out correctly. All good for testing. @SteamDeckHomebrew/decky-testers |
I update the plugin using test-store. The plugin works fine on Steam family beta and decky loader beta. |
A user other than the plugin developer needs to submit a testing report for the plugin to go to production. Thanks. |
Yeah I get it. I just report my test result. |
Testing on Stable Decky/SteamOS/Client; get error: [ERROR]: Failed to start DeckySpy! |
@aaburri Could you make another test? Swtich to desktop mode and then open a terminal. run I just notice there already have |
|
@TrainDoctor I have made an update. Still waiting for building the plugin. |
@aaburri I have done a test on my SteamDeck. Could you please do another test about the new version? Thanks. |
Not sure if this is supported but thought maybe I should report this On decky v3 stable , bazzite, steam game session, desktop pc the plugin seems to kill the decky process See: SteamDeckHomebrew/decky-loader#662 (comment) Uninstalling the decky spy plugin fixes those issues. I reinstalled it and the issues came back Left all settings at default values except the addition timer i set it to 2 hours and enabled it |
@zany130 Thanks for reporting. I don't have anyissue on SteamOS 3.5.19 and DeckyLoader v3.0.0. I will try to update OS and test again. |
Idk if this is maybe because of something in fedora( vs the arch base of steamos) which bazzite is based on maybe systemd's oom thing? |
From your log, it shows psutils library crash with some problem. This plugin current is using psutils that already in the system, since SteamOS seems have psutils installed. So there might be some problems with your system psutils. Maybe reinstall it (which may re-compile it) will solve this issue. |
I don't think bazzite has psutils at least I don't find it the path also you cant really "install or reinstall "packages on bazzite on the system level since its immutable just like steam os (technically you can overlay rpm packages but its recommended you don't) EDIT: NVM bazzite does seems to pre install EDIT2: it looks like the package has been updated since I last tried decky-spy. I will try it again after making sure I am fully up to date. otherwise I guess I should open a bug report on the package since steam-os psutil seems fine? |
It could be an issue with psutil, or it might be due to a misalignment between some underlying C++ dynamic library on your system and the version it was compiled with. It could also be caused by Python, because from the log you provided last time, psutil actually ran for a while before indicating a memory issue related to C.
You can check if your version differs from the one mentioned above. From my experience, the Python version and the psutil version mentioned above don't have any issues. |
Need testers for this. Giving until the end of the month for this plugin to receive a proper testing report or the PR will be closed. |
Does this mean I need to find a tester for testing? |
Yes, just like any other plugin update/submission. |
Decky 3.0.1, SteamOS 3.5.19
D) Yay |
Thanks for the review. Never heard of To Moon before though. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testers approve, off to production.
Decky Spy
Decky Spy is a plugin to monitor memory and processes on your Steam Deck. It depends on DeckyLoader.
Features
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing