-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated MicroSDeck Version #577
Updated MicroSDeck Version #577
Conversation
I did test on the preview channel although this was a long enough time ago that I would probably consider it not valid for these purposes. Also this PR has been raised early to allow for people to try the plugin in the testing store before it is finalized. A few more changes need to happen for this plugin to be updated to V1.0.0 and merged |
can someone greenlight this to release it on the testing store? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works perfect on SteamOS stable, Beat and Preview Update Channel.
Reminder that the PR is NOT yet ready to merge. BUT it should be published to the testing store so users can try it out. A version bump is required before the PR can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, no more 2000 billions line added :P
Good for testing in my book.
No 2000 lines, promise. All that is left to do is figure out the problem with the version & finish the documentation. |
14f32c2
to
b56fff9
Compare
Finally got around to pushing the fix that should ideally remove the wierd 0.0.0 version from the testing store. Can someone reapprove the Actions run so I can verify that the problem is fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes since last review look fine
b56fff9
to
6f06bb6
Compare
2822af0
to
9c7c10f
Compare
@CEbbinghaus, looking for confirmation from you that this is working on latest SteamOS Stable, once you can confirm that I can mark the plugin as ready for testing and will then try to summon testers as best I can. Thanks. |
I will test. Need to merge my documentation, Sorry I have been so busy its been really hectic IRL with family illness and having to move. Will try to get to it soon as possible. Sorry for all the delays 😥 |
Totally understand, and don't stress about it to much. Life comes fast and without warning. Take the time that you need. I'm basically just pulse checking everything to help making my life maintaining the plugin db easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works perfect on SteamOS Stable/ Beta an Preview Update Channel.
1e7437f
to
885d020
Compare
@CEbbinghaus I noticed your tasklist is not complete, if @nabel0 gives the latest version a test and confirms it's working is this good to merge? I don't want to put this out unfinished. |
Not quite yet sorry. Its getting very close but the tasklist is still not fully actioned. Going to try and finish it over the weekend |
I have made some good progress towards completing the plugin. Lots of small improvements. I will likely need a little help with my python script which is not nearly as reliable at keeping the backend running as I would like. Documentation is getting there but probably the slowest of all the things I have to do (not great at writing docs). So there has been progress but we aren't quite there yet (sorry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works perfect on SteamOS Stable/ Beta an Preview Update Channel.
We are getting close. At this point it is basically just the Docs, some QOL & bugfixes and lastly the version update. Most of the big boxes have been ticked |
Understood. If nabelo can come in and confirm that on the final commit where you feel ready to go then we're good to go at that point. |
Much appreciated. Sorry it's taken so long |
Pushed an update which fixes the build error. It just pins the docker container to the last good version while I figure out what is causing the build failure |
I'm starting to think that it may be smarter to just merge incrementally. Get a <1.0 version into master and just keep updating as the versions come in. It doesn't make sense gating all of this work behind documentation & other 1.0 tasks (including licensing & setting up code of conduct, etc...) @TrainDoctor You happy with that? (I'll add one update to at least add something into the docs but that is still a ways away from 1.0) |
Apologies for the delay in my response, whatever you feel works best for you. We just want to make sure what you're publishing provides the features you want without breaking anything! 😄 |
@nabel0 one last go for this PR review sorry, please make sure to include list of installed plugins, SteamOS versions, https://deckbrew.xyz/testing format basically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on SteamOS Stable, Beta and Preview Update Channel.
Works perfeclty fine.
Other Installed Plugins:
Storage CLeanner
Powertools
Moondeck
CSS Loader
Audio Loader
Tabmaster
Quick Launch
CHeatdeck
Steamgriddb
Game Theme Music
Autoflatpacks
Decky Terminal
Radiyo
Deckyfileserver
Animation Changer
Web Browser
Protondb Badges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Production! Yay!
MicroSDeck
Overhauled backend with lots of features and optimizations including:
just to name the big 3
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing