Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Emuchievements to 2.0.3 #520

Merged
merged 14 commits into from
Mar 15, 2024

Conversation

KP2048
Copy link
Contributor

@KP2048 KP2048 commented Jan 17, 2024

Update Emuchievements

Please include a summary of what the plugin does.

If this is an update, please include a summary of what changes you made.

Fixed a number of bugs and some major optimizations

[If you have not already, please read the review and testing page on the wiki. Remove this line before submitting your plugin.]

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes/No: I am using a custom backend other than Python.
  • Yes/No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes/No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

@KP2048 KP2048 requested a review from a team as a code owner January 17, 2024 14:53
…t them, add cache clear buttons and settings icon
Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@KP2048
Copy link
Contributor Author

KP2048 commented Mar 14, 2024

I need to push some changes I made so hold on a sec

@KP2048
Copy link
Contributor Author

KP2048 commented Mar 14, 2024

Should be good now, merge whenever

@KP2048
Copy link
Contributor Author

KP2048 commented Mar 14, 2024

function wise this has no impact on the plugin, it just adds a version identifier to the config so that i can detect when the user has an old config with a different format

@PartyWumpus PartyWumpus merged commit 4d3ee15 into SteamDeckHomebrew:main Mar 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants