Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kdeconnect plugin #491

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Add kdeconnect plugin #491

merged 7 commits into from
Dec 18, 2023

Conversation

safijari
Copy link
Contributor

@safijari safijari commented Dec 15, 2023

KDE Connect

When enabled, the plugin manages bringing up kdeconnect and switching over to a different instance of kdeconnect when going between the main UI and a game (because gamescope's use of xwayland is special). With this plugin basic keyboard and mouse input from kdeconnect is now possible in gamemode without any extra effort. Audio can also be adjusted.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@safijari safijari requested a review from a team as a code owner December 15, 2023 04:09
@TrainDoctor
Copy link
Member

@safijari please select a license or if you're sticking with the current license just put your username in there as appropriate. This will be a blocker before it can go to the production store but isn't an issue for going to the testing store. Thanks for your submission!

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crap, I missed the fact that you don't have a pnpm lockfile. You'll need to re-add that so the plugin will be able to build in CI.

@AAGaming00
Copy link
Member

btw assets isn't designed for scripts, it's served by the backend to the frontend to allow for displaying images and such

@safijari
Copy link
Contributor Author

btw assets isn't designed for scripts, it's served by the backend to the frontend to allow for displaying images and such

What's a better place for it?

@TrainDoctor
Copy link
Member

btw assets isn't designed for scripts, it's served by the backend to the frontend to allow for displaying images and such

What's a better place for it?

Best option imo would be to use the defaults folder as it would put the script in the root directory of the plugin during CI build.

@safijari
Copy link
Contributor Author

Alright. Did some restructuring and some clean up. This is good to go from my side.

@parkerlreed
Copy link

Working great. File transfers and remote control doing what they should.

@TrainDoctor TrainDoctor merged commit 3da9db0 into SteamDeckHomebrew:main Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants