Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Decky Custom Runner v0.0.2 #478

Closed
wants to merge 15 commits into from

Conversation

Alex4386
Copy link
Contributor

@Alex4386 Alex4386 commented Nov 26, 2023

Decky Custom Runner

This plugin allows you to run the other binaries inside the game installation both inside and outside of the game's proton environment, allowing you to launch game launchers (such as: rockstar social club) inside game-mode. Repository

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the default s directory unless you're using it for something in future. Once this is done the plugin is good to head to the plugin store.

Alex4386 added a commit to Alex4386/decky-custom-runner that referenced this pull request Nov 28, 2023
@Alex4386 Alex4386 changed the title Add Decky Custom Runner v0.0.1 Add Decky Custom Runner v0.0.2 Nov 28, 2023
@Alex4386
Copy link
Contributor Author

Please remove the default s directory unless you're using it for something in future. Once this is done the plugin is good to head to the plugin store.

Resolved at Alex4386/decky-custom-runner@37614f1

@Alex4386 Alex4386 requested a review from TrainDoctor November 28, 2023 03:11
@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/decky-testers has been ready for testing for a while.

@Alex4386
Copy link
Contributor Author

@SteamDeckHomebrew/decky-testers has been ready for testing for a while.

Yes, what should I do then

@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/decky-testers has been ready for testing for a while.

Yes, what should I do then

If you are in contact with a user, have them file a report based on this page: https://deckbrew.xyz/testing

@TrainDoctor
Copy link
Member

It has been over a month since PR was submitted, making a final call for interested @SteamDeckHomebrew/decky-testers. If no testers or end users file a testing report this submission will be closed until a tester participates in this thread.

@safijari
Copy link
Contributor

safijari commented Mar 6, 2024

Some remarks:

  • When pressing the "Start Custom Runner" button, the QAM does not close
  • There is no feedback as to what might have happened. Most of what I tried to run failed and I have no idea why
  • The only thing I was able to launch was Konsole. Any .exe that I tried to run in a game's prefix did not lead to anything launching

@TrainDoctor
Copy link
Member

Some remarks:

* When pressing the "Start Custom Runner" button, the QAM does not close

* There is no feedback as to what might have happened. Most of what I tried to run failed and I have no idea why

* The only thing I was able to launch was Konsole. Any .exe that I tried to run in a game's prefix did not lead to anything launching

These are significant enough issues I would consider them blocking. I'm closing the PR for now since it was opened in November. If the plugin developer would like to return to it and re-open the PR they are free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants