Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wine Cellar to 0.1.4 #476

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Update Wine Cellar to 0.1.4 #476

merged 1 commit into from
Nov 27, 2023

Conversation

FlashyReese
Copy link
Contributor

@FlashyReese FlashyReese commented Nov 23, 2023

Wine Cellar

  • Fixed installation issue when installing ProtonGE >=8.24

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

@FlashyReese FlashyReese requested a review from a team as a code owner November 23, 2023 12:41
@outerwinnie
Copy link

Working perfectly on 3.5.7, stable.

@TrainDoctor
Copy link
Member

TrainDoctor commented Nov 27, 2023

@SteamDeckHomebrew/decky-testers, still requires testing on preview.

@AlexFolland
Copy link

If this matters, I have tested this in the "Main" SteamOS update channel which is only visible by enabling advanced update channels, and it works there as well. I was able to download the latest Proton-GE using Wine Cellar 0.1.4 on my new Steam Deck OLED running SteamOS from the "Main" update channel.

@TrainDoctor
Copy link
Member

If this matters, I have tested this in the "Main" SteamOS update channel which is only visible by enabling advanced update channels, and it works there as well. I was able to download the latest Proton-GE using Wine Cellar 0.1.4 on my new Steam Deck OLED running SteamOS from the "Main" update channel.

That's basically just preview++, so totally works. Appreciate your willingness to test. Thanks!

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testers give their approval, sending to production.

@TrainDoctor TrainDoctor merged commit b16aa8d into SteamDeckHomebrew:main Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants