Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decky-xrealAir to include changes to include breezy-desktop's … #464

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

wheaney
Copy link
Contributor

@wheaney wheaney commented Oct 23, 2023

…vulkan implementation

XREAL Air Gaming

This plugin installs the latest version of the XREAL driver and Breezy Desktop's Vulkan implementation (virtual display for Vulkan games).

This is an update to a plugin already in the store. The previous version of the plugin installed just the base XREAL driver, which allowed for mouse or joystick tracking of head movements. This version installs my breezy-desktop client, which is a Vulkan shader used to render a virtual display that tracks against head movements provided by an updated version of the same base XREAL driver as before. So the updates to this package include:

  • Switching from installing the XREAL driver to installing Breezy Desktop (which installs the XREAL driver under the hood). As before, all binaries are packaged and included with the build of decky-xrealAir, so nothing gets downloaded during installation.
  • Updating the decky plugin UI to include the new driver mode and controls needed for it.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Preview Update Channel.

@wheaney wheaney requested a review from a team as a code owner October 23, 2023 17:49
@wheaney wheaney temporarily deployed to testing_env October 23, 2023 18:32 — with GitHub Actions Inactive
@TrainDoctor
Copy link
Member

Code review looks good, sending to the testing store.

@TrainDoctor TrainDoctor requested a review from a team October 24, 2023 00:35
@wheaney wheaney temporarily deployed to testing_env October 24, 2023 01:48 — with GitHub Actions Inactive
Copy link

@stephen-cornwell stephen-cornwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Report

Versions Tested

Decky version(s): v2.10.5
SteamOS version(s): 3.4.11 (Beta Channel)

Testing Details

A) Any major blocking issues that you encountered, if any.
No blocking/major issues.

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
Occasional drag (the display in the glasses is a little slow to keep up with head movement) when framerates drop.

C) A list of currently installed plugins (Name and version preferred)

  • ProtonDB Badges (1.0.11)
  • SteamGridDB (1.3.1)
  • vibrantDeck (1.4.1)

D) Yay/nay on to send to the production store or if it requires more testing.
Yes - good to go to the production store.

@TrainDoctor
Copy link
Member

Good to go!

If you are submitting a testing report please make sure to follow this template guide: https://deckbrew.xyz/testing

@wheaney
Copy link
Contributor Author

wheaney commented Oct 24, 2023

If you are submitting a testing report please make sure to follow this template guide: https://deckbrew.xyz/testing

Thanks, this was my bad, I forgot to provide that link.

@wheaney
Copy link
Contributor Author

wheaney commented Oct 24, 2023

A couple things before this goes to prod:

  1. There are two plugins appearing in the test store right now: XREAL Air Driver and XREAL Air Gaming. The former is the old one and should be removed, assuming the store is using the name as an identifier and I didn't just misconfigure my plugin somehow.
  2. I have a couple small tweaks I'd like to get in based on some testing I'm doing tonight. I'd like to be able to patch those into this PR before it goes out.

@stephen-cornwell
Copy link

stephen-cornwell commented Oct 24, 2023

Good to go!

If you are submitting a testing report please make sure to follow this template guide: https://deckbrew.xyz/testing

@TrainDoctor I've updated my comment with test report as requested: #464 (review)

@drcursor
Copy link

Test Report
Versions Tested
Decky version(s): v2.10.5
SteamOS version(s): 3.5.1 (Beta Channel)

Testing Details
A) Any major blocking issues that you encountered, if any.
Nothing of note.

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
Screen drag still needs some work (not breaking). No support for some games/apps.

C) A list of currently installed plugins (Name and version preferred)

ProtonDB Badges (1.0.11)
Controller Tools 1.1.2-1
Bluetooth 2.1.0
AutoFlatPacks 1.6.5
HLTB for Deck 1.31.
Metadeck 2.0.1
MoonDeck 1.6.0
SteamGridDB (1.3.1)

D) Yay/nay on to send to the production store or if it requires more testing.
Yes - Stable and working as intended

@wheaney wheaney temporarily deployed to testing_env October 24, 2023 18:07 — with GitHub Actions Inactive
@wheaney
Copy link
Contributor Author

wheaney commented Oct 24, 2023

Latest changes are fully tested and ready to go. I've rebranded the plugin back to XREAL Air Driver so there aren't two plugins.

@SkyLeite
Copy link
Collaborator

Decky version(s), SteamOS version(s)
A) Any major blocking issues that you encountered, if any.
None

B) Any minor issues that you encountered (usually cosmetic, don't harm functionality).
None

C) A list of currently installed plugins (Name and version preferred)
None, apart from my personal plugins

(This list is needed due to potential conflicts between plugins etc).
D) Yay/nay on to send to the production store or if it requires more testing.
Looks good to me.

@wheaney
Copy link
Contributor Author

wheaney commented Oct 24, 2023

@SkyLeite do you mind triggering a retry of the "Build plugin" task? It failed upload again.

@wheaney wheaney temporarily deployed to testing_env October 24, 2023 22:29 — with GitHub Actions Inactive
@wheaney wheaney temporarily deployed to testing_env October 24, 2023 22:31 — with GitHub Actions Inactive
@wheaney wheaney temporarily deployed to testing_env October 24, 2023 23:30 — with GitHub Actions Inactive
@wheaney wheaney temporarily deployed to testing_env October 24, 2023 23:33 — with GitHub Actions Inactive
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload is good, sending to production.

@TrainDoctor TrainDoctor merged commit 14beb83 into SteamDeckHomebrew:main Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants