-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenDeckStream plugin #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the wiki and remove any unused folders (defaults) as well as adding entries to plugin.json etc. I will be doing code review at another time due to time constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly does this need root access? can OBS not capture as the user?
also consider building OBS in release mode instead of debug |
I'll try removing root permissions and seeing what happens, I was originally having issues with capturing as none root but that might be fixed now
|
perhaps RelWithDebInfo could be good |
The version in the testing store don't work at all. I think there is some important stuff missing in this release. It's way to smal. |
I hadn't committed my change to the dockerfile, so it was still trying looking for a local image. Next build should work. (Strange how the CI passed though) |
OpenDeckStream
A recording plugin that uses OBS as it's backend.
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing