Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenDeckStream plugin #463

Closed
wants to merge 6 commits into from
Closed

Conversation

Epictek
Copy link

@Epictek Epictek commented Oct 23, 2023

OpenDeckStream

A recording plugin that uses OBS as it's backend.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Preview Update Channel.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the wiki and remove any unused folders (defaults) as well as adding entries to plugin.json etc. I will be doing code review at another time due to time constraints.

@Epictek Epictek temporarily deployed to testing_env October 24, 2023 16:33 — with GitHub Actions Inactive
Copy link
Member

@AAGaming00 AAGaming00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exactly does this need root access? can OBS not capture as the user?

@AAGaming00
Copy link
Member

also consider building OBS in release mode instead of debug

@Epictek
Copy link
Author

Epictek commented Oct 24, 2023

Why exactly does this need root access? can OBS not capture as the user?

I'll try removing root permissions and seeing what happens, I was originally having issues with capturing as none root but that might be fixed now

also consider building OBS in release mode instead of debug
Will do have finished debugging any issues with pipewire that arise

@AAGaming00
Copy link
Member

Will do have finished debugging any issues with pipewire that arise

perhaps RelWithDebInfo could be good

@Epictek Epictek temporarily deployed to testing_env October 24, 2023 17:12 — with GitHub Actions Inactive
@Epictek Epictek temporarily deployed to testing_env October 24, 2023 21:51 — with GitHub Actions Inactive
@nabel0
Copy link

nabel0 commented Oct 24, 2023

The version in the testing store don't work at all. I think there is some important stuff missing in this release. It's way to smal.

@Epictek
Copy link
Author

Epictek commented Oct 25, 2023

The version in the testing store don't work at all. I think there is some important stuff missing in this release. It's way to smal.

I hadn't committed my change to the dockerfile, so it was still trying looking for a local image. Next build should work.

(Strange how the CI passed though)

@TrainDoctor TrainDoctor self-requested a review October 25, 2023 01:19
@Epictek Epictek temporarily deployed to testing_env October 25, 2023 17:00 — with GitHub Actions Inactive
@Epictek Epictek temporarily deployed to testing_env October 27, 2023 18:11 — with GitHub Actions Inactive
@Epictek Epictek temporarily deployed to testing_env October 27, 2023 23:16 — with GitHub Actions Inactive
@Epictek Epictek temporarily deployed to testing_env October 28, 2023 03:38 — with GitHub Actions Inactive
@Epictek Epictek closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants