Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmuDecky update v.1.0.2 #459

Merged
merged 11 commits into from
Dec 9, 2023
Merged

Conversation

dragoonDorise
Copy link
Contributor

@dragoonDorise dragoonDorise commented Oct 10, 2023

EmuDecky

Decky Loader plugin to manage EmuDeck CloudSync and Quick Settings.

Update 1.0.2: Removed loop of death when offline.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@dragoonDorise dragoonDorise requested a review from a team as a code owner October 10, 2023 09:46
@dragoonDorise dragoonDorise changed the title Emu decky EmuDecky update v.1.0.1 Oct 10, 2023
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
@dragoonDorise dragoonDorise temporarily deployed to testing_env October 10, 2023 09:47 — with GitHub Actions Inactive
Copy link
Contributor

@RodoMa92 RodoMa92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrainDoctor
Copy link
Member

@dragoonDorise, if possible please see if you can get some people willing to test from your community. Have them follow this form: https://deckbrew.xyz/testing

@dragoonDorise dragoonDorise changed the title EmuDecky update v.1.0.1 EmuDecky update v.1.0.2 Oct 26, 2023
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragoonDorise please rebase your PR onto latest version of this repo, update your LICENSE file to include the respective license you are using with the original license below in the same file and remove the defaults folder and it's contents if you are not using that folder and it's functionality. Thanks.

@TrainDoctor TrainDoctor requested a review from RodoMa92 November 1, 2023 23:35
@dragoonDorise
Copy link
Contributor Author

@TrainDoctor done!

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, didn't notice Rod's review until now. Sending to production.

@TrainDoctor TrainDoctor merged commit 914f7d0 into SteamDeckHomebrew:main Dec 9, 2023
11 checks passed
@dragoonDorise dragoonDorise deleted the EmuDecky branch September 27, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants