Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DeckScreenshotManager #456

Merged
merged 9 commits into from
Nov 14, 2023
Merged

add DeckScreenshotManager #456

merged 9 commits into from
Nov 14, 2023

Conversation

codehz
Copy link
Contributor

@codehz codehz commented Oct 4, 2023

Screenshot Uploader

Valve does not implement auto-upload screenshot for us, so I added it.

See: https://steamcommunity.com/app/1675200/discussions/2/6117591738155117046/

It is a simple plugin, no custom backend code is needed, all functionality is implemented in js (except for saving/loading setting, which is implemented in python), reuse SteamClient API.

Do not confuse with the Shotty plugin, since it is used to link screenshot to Picture folder.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

@codehz codehz requested a review from a team as a code owner October 4, 2023 20:15
@codehz codehz temporarily deployed to testing_env October 5, 2023 09:10 — with GitHub Actions Inactive
@codehz codehz temporarily deployed to testing_env October 5, 2023 09:12 — with GitHub Actions Inactive
@codehz codehz temporarily deployed to testing_env October 5, 2023 15:18 — with GitHub Actions Inactive
@codehz codehz temporarily deployed to testing_env October 6, 2023 13:38 — with GitHub Actions Inactive
@TrainDoctor TrainDoctor requested a review from a team October 23, 2023 02:15
@codehz codehz temporarily deployed to testing_env October 23, 2023 02:18 — with GitHub Actions Inactive
@TrainDoctor
Copy link
Member

@SteamDeckHomebrew/decky-testers ready for testing.

Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine on SteamOS Stable/Beta Update Channel.

@TrainDoctor TrainDoctor merged commit fddc605 into SteamDeckHomebrew:main Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants