-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update tabmaster to v2.0.0 #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I updated, the injection was totally broken. I forgot to take a screenshot, and it was fixed with a reboot. iirc the issue was tabs.find is not a function
.
Otherwise, the code looks good and all the new features work flawlessly, although I can't test the multiple account thing (the migration worked though).
I believe this is a valve issue, as that call is on a list of tabs gotten using a function valve wrote. Glad to hear everything else is working reliably. We did a lot of testing on it ourselves |
Hmm that's very strange. That would indicate that the function that is supposed to return the original tabs is not actually returning an array. Hopefully, it was just a one off thing. If anyone else has the issue we'll look further into it and see if valve changed something. |
Updated it on my PC and got the same issue. First it showed Again, it goes away after i reload steam. Also, I have a large number of other plugins, so it could be conflicting with those, I can do further testing without them if wanted. |
We'll do some testing and lyk if it seems to be a conflict issue or a bug |
Do you have playtime installed and on decky stable? |
Hmm it shouldn’t be that unless you are running decky < 2.10.4. What version are you on? Also what branch of steam? |
TabMaster
Major update for TabMaster, with a bunch of fixes, new features, and filters. Changelog can be found here
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing
(cc @jessebofill )