Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tabmaster to v2.0.0 #440

Merged
merged 12 commits into from
Sep 18, 2023
Merged

Conversation

Tormak9970
Copy link
Contributor

TabMaster

Major update for TabMaster, with a bunch of fixes, new features, and filters. Changelog can be found here

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable/Beta Update Channel.

(cc @jessebofill )

@Tormak9970 Tormak9970 requested a review from a team as a code owner September 7, 2023 22:54
@Tormak9970 Tormak9970 temporarily deployed to testing_env September 7, 2023 22:55 — with GitHub Actions Inactive
Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I updated, the injection was totally broken. I forgot to take a screenshot, and it was fixed with a reboot. iirc the issue was tabs.find is not a function.

Otherwise, the code looks good and all the new features work flawlessly, although I can't test the multiple account thing (the migration worked though).

@Tormak9970
Copy link
Contributor Author

When I updated, the injection was totally broken. I forgot to take a screenshot, and it was fixed with a reboot. iirc the issue was tabs.find is not a function.

Otherwise, the code looks good and all the new features work flawlessly, although I can't test the multiple account thing (the migration worked though).

I believe this is a valve issue, as that call is on a list of tabs gotten using a function valve wrote. Glad to hear everything else is working reliably. We did a lot of testing on it ourselves

@jessebofill
Copy link
Contributor

Hmm that's very strange. That would indicate that the function that is supposed to return the original tabs is not actually returning an array. Hopefully, it was just a one off thing. If anyone else has the issue we'll look further into it and see if valve changed something.

@PartyWumpus
Copy link
Member

Updated it on my PC and got the same issue. First it showed Cannot read property of undefined, then if I click refresh and go to any other page than the library page it says tabs.find is not a function. The library still says Cannot read property of undefined.
Here's the log and a picture of what looks to be the problem:
steamloopback.host-1694298699190.log
image

Again, it goes away after i reload steam. Also, I have a large number of other plugins, so it could be conflicting with those, I can do further testing without them if wanted.

@Tormak9970
Copy link
Contributor Author

Updated it on my PC and got the same issue. First it showed Cannot read property of undefined, then if I click refresh and go to any other page than the library page it says tabs.find is not a function. The library still says Cannot read property of undefined.
Here's the log and a picture of what looks to be the problem:
steamloopback.host-1694298699190.log
image

Again, it goes away after i reload steam. Also, I have a large number of other plugins, so it could be conflicting with those, I can do further testing without them if wanted.

We'll do some testing and lyk if it seems to be a conflict issue or a bug

@jessebofill
Copy link
Contributor

Updated it on my PC and got the same issue. First it showed Cannot read property of undefined, then if I click refresh and go to any other page than the library page it says tabs.find is not a function. The library still says Cannot read property of undefined. Here's the log and a picture of what looks to be the problem: steamloopback.host-1694298699190.log image

Again, it goes away after i reload steam. Also, I have a large number of other plugins, so it could be conflicting with those, I can do further testing without them if wanted.

Do you have playtime installed and on decky stable?

@jessebofill
Copy link
Contributor

Updated it on my PC and got the same issue. First it showed Cannot read property of undefined, then if I click refresh and go to any other page than the library page it says tabs.find is not a function. The library still says Cannot read property of undefined. Here's the log and a picture of what looks to be the problem: steamloopback.host-1694298699190.log image
Again, it goes away after i reload steam. Also, I have a large number of other plugins, so it could be conflicting with those, I can do further testing without them if wanted.

Do you have playtime installed and on decky stable?

Hmm it shouldn’t be that unless you are running decky < 2.10.4. What version are you on? Also what branch of steam?

@Tormak9970 Tormak9970 temporarily deployed to testing_env September 10, 2023 16:17 — with GitHub Actions Inactive
@RodoMa92 RodoMa92 merged commit 9b96455 into SteamDeckHomebrew:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants