Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeckyTerminal to v0.2.5 #426

Merged
merged 10 commits into from
Aug 29, 2023
Merged

Conversation

Alex4386
Copy link
Contributor

@Alex4386 Alex4386 commented Aug 25, 2023

Decky Terminal

This plugin adds missing terminal emulator in game-mode. providing access to terminal while playing games.

Changelog

What's new on v0.2.0:

  • Fullscreen mode
  • DPad based navigation support (BETA)
  • Settings menu
  • Display's terminal title instead of internal terminal id
  • Option to change default shell
  • Option to change font family (a.k.a. Nerd Font support)
  • Option to change font size

What's new on v0.2.1:

  • Revert decky_plugin.pyi changes

What's new on v0.2.2:

  • Add option to disable virtual keyboard

What's new on v0.2.3:

  • Fixed settings are not properly shown when default shell is being used

What's new on v0.2.4:

  • Fixed terminal title linewrapping

What's new on v0.2.5:

  • Fixed websocket payload pollution on terminal sessions

For more information, Please check the changelog available at:

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

@Alex4386 Alex4386 requested a review from a team as a code owner August 25, 2023 18:31
@Alex4386 Alex4386 changed the title Update DeckyTerminal to ver.0.2.0 Update DeckyTerminal to v0.2.0 Aug 25, 2023
@TrainDoctor TrainDoctor requested a review from a team August 25, 2023 19:24
@TrainDoctor
Copy link
Member

@Alex4386 decky_plugin.pyi shouldn't have it's values changed unless Decky Loader's equivalent of the file changes.

Alex4386 added a commit to Alex4386/decky-terminal that referenced this pull request Aug 26, 2023
Alex4386 added a commit to Alex4386/decky-terminal that referenced this pull request Aug 26, 2023
@Alex4386
Copy link
Contributor Author

Alex4386 commented Aug 26, 2023

@Alex4386 decky_plugin.pyi shouldn't have it's values changed unless Decky Loader's equivalent of the file changes.

@TrainDoctor Reverted the following at Alex4386/decky-terminal@fef8c72.

@Alex4386 Alex4386 changed the title Update DeckyTerminal to v0.2.0 Update DeckyTerminal to v0.2.1 Aug 26, 2023
@Alex4386 Alex4386 changed the title Update DeckyTerminal to v0.2.1 Update DeckyTerminal to v0.2.2 Aug 26, 2023
@Alex4386 Alex4386 changed the title Update DeckyTerminal to v0.2.2 Update DeckyTerminal to v0.2.3 Aug 26, 2023
@Alex4386 Alex4386 temporarily deployed to testing_env August 27, 2023 17:14 — with GitHub Actions Inactive
@Alex4386 Alex4386 changed the title Update DeckyTerminal to v0.2.3 Update DeckyTerminal to v0.2.5 Aug 27, 2023
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the setting for the default shell type is not saved and switches always back to "/bin/sh"

Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the setting for the default shell type is not saved and switches always back to "/bin/sh"

The setting works, it just visually resets afterwards. I notice you forgot the empty list at the end of useEffect in the SettingsPage.tsx so it runs every time anything updates, but I can't really tell why the setting isn't working visually.

Otherwise looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants