-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decky-syncthing #406
Add decky-syncthing #406
Conversation
Found the review and testing page at https://wiki.deckbrew.xyz/en/plugin-dev/review-and-testing - will review that now! |
e8664b7
to
da31373
Compare
Reviewed the page and removed the assets directory. |
da31373
to
2a7ee67
Compare
Changed banner to be a PNG. |
You should probably have something in the plugin that mentions that the syncthing flatpak has to be installed, as users are likely to go in with zero knowledge.
Also I can see you're using the custom scrollable element, hopefully that can be replaced by scrollGroup and friends when SteamDeckHomebrew/decky-frontend-lib#90 gets merged. |
We noticed that OpenSSL 1.1 was apparently not guaranteed to be installed on a Deck, so I'm switching to a statically linked TLS implementation. |
2a7ee67
to
90f8e44
Compare
I replaced the link to OpenSSL with the statically compiled Additionally I updated the README and the description in the |
90f8e44
to
9962e3c
Compare
9962e3c
to
d13b333
Compare
Sorry I took so long to get back around to this. The plugin mostly functions well (entering the API key was a little tedious). However, the actual disabling/enabling of folders doesn't seem to work, they don't do anything when clicked on. (ignore the errors in the console, they seem unrelated) 2023-08-11.20-35-27_7MB.mp4 |
For now that's on purpose. Eventually I'll probably make it so that clicking the folders and devices shows some details. |
Ah okay, guess it's all working fine then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
decky-syncthing (Syncthing)
From the README:
NOTE: This PR template contained a link asking me to review https://deckbrew.xyz/en/plugin-dev/review-and-testing - this page does not exist! So I did not review that page.
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
The Rust backend is mostly statically linked but does rely on some very standard system libs like OpenSSL 1.1.
Testing