Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bash Shortcuts to v2.0.0 #291

Merged
merged 12 commits into from
May 5, 2023

Conversation

Tormak9970
Copy link
Contributor

@Tormak9970 Tormak9970 commented Mar 17, 2023

Bash Shortcuts Update v2.0.0

Bash Shortcuts is now feature complete.

Changes:

  • Switched to the new reorderable list
  • Added support for running multiple shortcuts at once
  • Switched over to instance model
  • Plugin now deletes any leftover instances on boot
  • Added support for killing long running shortcuts
  • Plugin now uses the new decky log directory
  • Plugin now uses the new decky settings manager
  • UI now updates properly when the shortcut is exited from outside the plugin
  • Added custom deployment scripts
  • Implemented websockets to allow for backend -> frontend communication
  • Non app shortcuts now show a toast when the finish
  • Switched the manager window to be called config and added icons to better align with Steam’s settings window
  • Plugin now has a setting for WebSocket Port
  • Fixed apps not opening fullscreen
    • Switched to xdotool
  • Fixed the error that was showing up in konsole when launched
    • Switched command to “LD_PRELOAD= QT_SCALE_FACTOR=1.25 konsole”
  • Added setting to enable/disable flags
  • All non app shortcuts are now given 5 flags
    • Date
    • Time
    • Current user
    • Current game appId (if there is one)
    • Current game name (if there is one)
  • Added guides to config window
  • Using Markdown-it for parsing the markdown
  • Overview - overview of plugin and guides
  • Managing Shortcuts - explains functions of the plugin
  • Custom Scripts - explains a bit about bash and some troubleshooting tips
  • Using hooks - explains the usage of hooks
  • Added hooks for:
    • Log in
    • Log out
    • Game start
    • Game end
    • Game install
    • Game update
    • Game uninstall
    • Achievement unlocked
    • Screenshot taken
    • Deck sleep
    • Deck shutdown
  • Plugin now checks if shortcut is running when edited/deleted and kill it

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable Update Channel.
  • Tested on SteamOS Beta Update Channel.

@Tormak9970 Tormak9970 requested a review from a team as a code owner March 17, 2023 17:18
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python side good code wise, requested the more typescript and react side of the loader team to review that side of this PR before sending to testing.

@TrainDoctor TrainDoctor requested a review from a team March 18, 2023 17:41
@Tormak9970 Tormak9970 temporarily deployed to testing_env March 20, 2023 03:56 — with GitHub Actions Inactive
@TopHatHipster
Copy link

Currently on:

  • Steam OS Beta Candidate
  • Steam Deck Beta Client
  • Decky Loader v2.6.5-pre2
  • Bash Shortcuts 2.0.0-df08b1f (latest version on the Testing store currently)

Using a simple shortcut (with command: konsole), it seems to work just fine to boot as an app.

However, apologies for my lack of knowledge how to properly test this plugin: got any command to test with, by any chance? To test the flags/hooks with at the moment.
Using the konsole command, setting it to use flags and use the Screenshot Taken hook for example does not boot it up in the background (as the green rocket icon "Ready to Launch" indicator is still present, rather than the "actively running" icon when running the app).

Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On stable client/steam OS/decky and on the most recent version of bash shortcuts in the testing store.
All the features appear to work well, although I haven't tested every flag/hook.
The built-in documentation scrolls a little weirdly, but functions well enough and will likely be replaced by decky's #432 eventually anyways. The actual text in the docs is very helpful.
I've taken a look at the typescript and it all looks good, although I'm not a typescript master.
I think it looks good to go.

@PartyWumpus PartyWumpus merged commit a0cd8c7 into SteamDeckHomebrew:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants