[Feature] Warn users on possible risks on installing third party unvetted plugins #600

RodoMa92 · 2024-03-13T14:49:44Z

Please tick as appropriate:

I have tested this code on a steam deck or on a PC
My changes generate no new errors/warnings
This is a bugfix/hotfix
This is a new feature

Description

This PR implements proper warning messages for third party install outside our store to warn users of potential malicious code outside our ecosystem.

…teamDeckHomebrew#540) this prevents needless prompts opening up

… Valve Internal

look i was tired when writing yesterday's fix okay

…rew#539) This can prevent race conditions where unload is clearing data but main is still working with it

* Added translation using Weblate (Japanese) * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Translated using Weblate (Japanese) Currently translated at 82.7% (115 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 89.2% (124 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/ --------- Co-authored-by: Tak-attack <[email protected]> Co-authored-by: Weblate <[email protected]> Co-authored-by: Fábio Oliveira <[email protected]>

…eckHomebrew#575) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.6.3 to 41.0.0. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v35.6.3...v41.0.0) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add new user agent to do not close tabs list * fix: bump DFL to fix chromium 109 beta --------- Co-authored-by: Sims <[email protected]>

@eXhumer

Add another name placeholder for getting the toaster out of the HTML tree. Thanks to @eXhumer for the fix.

* Added translation using Weblate (Japanese) * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Translated using Weblate (Japanese) Currently translated at 82.7% (115 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 89.2% (124 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/ --------- Co-authored-by: Tak-attack <[email protected]> Co-authored-by: Weblate <[email protected]> Co-authored-by: Fábio Oliveira <[email protected]>

fixes toaster error on latest beta

Fixes an issue where act wouldn't use the correct container and so couldn't find a compatible python version, so it would fail to build.

…teamDeckHomebrew#547) * untested first commit * fix types & names * comment out built in sorting for now * rerun search when sort changes * fix ts complaints * use prettier * stop switch-case fall through * move spinner * use locale instead of hardcoded string * fix typo * add sorting by downloads & try using the data field in the dropdown for data * fix typing error * fix asc/desc in dropdown * fix asc/desc again. asc = smaller one go first aaaaa * I don't think i know what ascending means maybe * use props instead of children, like a normal component

…eckHomebrew#539)" (SteamDeckHomebrew#584) This reverts commit 39f4f28 , because functions (seemingly) don't run after the event loop closes, so the unload function is never actually run.

…mDeckHomebrew#585)

* git no work so manually uploading files :( * argh i wish git was working * ok next time i'll make git work * Update updater.py * git please work next time this took ages without you * fix me locales * Update updater.py * Update en-US.json * Update updater.py * Update updater.py * i wish my python LSP stuff was working * fix it * Update updater.py * Update updater.py * Only show testing branch as an option if it is already selected * Initial implementation for fetching the open PRs. Still need testing and a token to complete this. * Wrong filter capitalization * Fix a couple of typos in the python backend updater. * Fix typos pt 3 * This should be the last one * Prepend the PR version number with PR- to make it clearer that's the PR number. * Update prettier to the latest version otherwise it will never be happy with the formatting. * fix merge mistake * fix pyright errors & type hint most new code * fix strict pyright errors... * not sure why my local linter didn't catch this * Reimplement the logic between PR and artifact build to limit API calls * Fix pyright errors * use nightly.link for downloads * remove accidental dollar sign * fix various logical errors. the code actually works now. * set branch to testing when user downloads a testing version --------- Co-authored-by: Marco Rodolfi <[email protected]>

…ebrew#578) * fix: get plugin name for dev builds from ZIP (SteamDeckHomebrew#527) Signed-off-by: eXhumer <[email protected]>

i must have done a great deal of harm in a past life to deserve this mistreatment by formatting tools. why do they hate me.

* Added translation using Weblate (Japanese) * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Update translation files Updated by "Remove blank strings" hook in Weblate. Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ * Translated using Weblate (Japanese) Currently translated at 82.7% (115 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 89.2% (124 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Japanese) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/ja/ * Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_PT/ * Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/pt_BR/ * Translated using Weblate (French) Currently translated at 91.3% (127 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/fr/ * Translated using Weblate (Dutch) Currently translated at 100.0% (139 of 139 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/nl/ * Translated using Weblate (English) Currently translated at 100.0% (147 of 147 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/en/ * Translated using Weblate (Italian) Currently translated at 100.0% (147 of 147 strings) Translation: Decky/Decky Translate-URL: https://weblate.werwolv.net/projects/decky/decky/it/ --------- Co-authored-by: Tak-attack <[email protected]> Co-authored-by: Weblate <[email protected]> Co-authored-by: Fábio Oliveira <[email protected]> Co-authored-by: Andrew Moore <[email protected]> Co-authored-by: Danae Dekker <[email protected]> Co-authored-by: Marco Rodolfi <[email protected]>

bumps decky-frontend-lib to 3.25.0 can't stop us THAT easily :P

…party repositories and plugins

JohnnyCrazy

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

EMERALD0874

I have some non-blocking requested changes regarding the language, but the code changes look great!

backend/locales/en-US.json

RodoMa92 · 2024-03-14T12:57:26Z

Nice, LGTM!

I think the TranslationHelper might be doing too much tho and grow into oblivion, maybe separate functions/helpers in the components would be better in the long term.

Yeah, I agree, I just need to find a decent place to place them without adding too much clutter in the structure of the project. I'll probably do this not too far down the line.

TrainDoctor · 2024-08-06T17:36:31Z

@RodoMa92 do you want to proceed with these changes or would refactoring to latest main be to difficult?

RodoMa92 · 2024-08-09T07:07:40Z

I'll close my two PRs and will readd them on top, too much changes on top of main to cleanly rebase them.

AAGaming00 and others added 30 commits November 9, 2023 15:35

fix: get rid of title view jank on latest beta

29d651b

Count the number of installs for each plugin (SteamDeckHomebrew#557)

8f26fde

Bump aiohttp from 3.8.4 to 3.8.5 in /backend (SteamDeckHomebrew#558)

479a16c

Check if Linux service is running before trying to start or stop it (S…

75ad98a

…teamDeckHomebrew#540) this prevents needless prompts opening up

replace chmod implementation with os.chmod (SteamDeckHomebrew#541)

7c3ae9b

bump dfl

91186da

fix: Adjust tabs and toaster hooks to work on react 18, also half-fix…

80a00a0

… Valve Internal

fix: idiotic formatting error i should have noticed

e21a5d5

fix(developer): add back valve internal on beta

3489fd7

look i was tired when writing yesterday's fix okay

Call plugin unload function after stopping event loop (SteamDeckHomeb…

39f4f28

…rew#539) This can prevent race conditions where unload is clearing data but main is still working with it

fix: Fix on Chromium 109 beta (SteamDeckHomebrew#576)

f9a07da

* Add new user agent to do not close tabs list * fix: bump DFL to fix chromium 109 beta --------- Co-authored-by: Sims <[email protected]>

Bump aiohttp from 3.8.5 to 3.9.0 in /backend (SteamDeckHomebrew#577)

9295e4b

[Bugfix] Toaster changed name again (SteamDeckHomebrew#581)

3146ebf

Add another name placeholder for getting the toaster out of the HTML tree. Thanks to @eXhumer for the fix.

fix the tasks

6b4a56c

fix: use findInReactTree to find correct errorboundary for toaster

7f2caa3

fixes toaster error on latest beta

fix: bump dfl to fix error on latest steam beta

62e3128

Specify catthehacker/ubuntu:act-22.04 as container for act

3e4c255

Fixes an issue where act wouldn't use the correct container and so couldn't find a compatible python version, so it would fail to build.

Revert "Call plugin unload function after stopping event loop (SteamD…

2500b74

…eckHomebrew#539)" (SteamDeckHomebrew#584) This reverts commit 39f4f28 , because functions (seemingly) don't run after the event loop closes, so the unload function is never actually run.

fix(filepicker_ls): use case insensitive matching for file exts (Stea…

435dfa7

…mDeckHomebrew#585)

Get plugin name for development ZIP during installation (SteamDeckHom…

0dce3a8

…ebrew#578) * fix: get plugin name for dev builds from ZIP (SteamDeckHomebrew#527) Signed-off-by: eXhumer <[email protected]>

[Feature] Freeze updates for devs (SteamDeckHomebrew#582)

7d6b880

fix finding qam root node for feb 14th beta

ecf4800

Appease prettier

922d0c4

i must have done a great deal of harm in a past life to deserve this mistreatment by formatting tools. why do they hate me.

Update bug_report.yml

55a95e0

TrainDoctor and others added 4 commits February 23, 2024 16:19

Update bug_report.yml

8e8e6a2

fix: support new minified class names

4a7e9a5

bumps decky-frontend-lib to 3.25.0 can't stop us THAT easily :P

Initial implementation to warn users of potential dangers from third …

056f921

…party repositories and plugins

Fixing spelling mistakes

a1b4040

RodoMa92 changed the title ~~Warn third party~~ Warn users on possible risks on installing third party unvetted plugins Mar 13, 2024

RodoMa92 changed the title ~~Warn users on possible risks on installing third party unvetted plugins~~ [Feature] Warn users on possible risks on installing third party unvetted plugins Mar 13, 2024

Added a wait time only for the first popup message on both warnings.

05f9a3b

JohnnyCrazy approved these changes Mar 13, 2024

View reviewed changes

EMERALD0874 reviewed Mar 14, 2024

View reviewed changes

Simplified and cleared up text warnings

314e812

AAGaming00 force-pushed the main branch from 785ef02 to d71fb79 Compare June 27, 2024 05:53

TrainDoctor assigned RodoMa92 Aug 6, 2024

TrainDoctor added the enhancement New feature or request label Aug 6, 2024

Marco Rodolfi added 3 commits August 6, 2024 20:45

Merge branch 'main' into warn_third_party

cfd4f40

Adapt commits to latest changes

2bd47cf

Readapt class parameters to main

b3f26d9

RodoMa92 closed this Aug 9, 2024

RodoMa92 deleted the warn_third_party branch August 9, 2024 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

RodoMa92 commented Mar 13, 2024

JohnnyCrazy left a comment

EMERALD0874 left a comment •

edited

Loading

RodoMa92 commented Mar 14, 2024

TrainDoctor commented Aug 6, 2024

RodoMa92 commented Aug 9, 2024

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

[Feature] Warn users on possible risks on installing third party unvetted plugins #600

Conversation

RodoMa92 commented Mar 13, 2024

Description

JohnnyCrazy left a comment

Choose a reason for hiding this comment

EMERALD0874 left a comment • edited Loading

Choose a reason for hiding this comment

RodoMa92 commented Mar 14, 2024

TrainDoctor commented Aug 6, 2024

RodoMa92 commented Aug 9, 2024

EMERALD0874 left a comment •

edited

Loading