Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin store and add sorting by downloads and release date #547

Merged
merged 17 commits into from
Feb 7, 2024

Conversation

PartyWumpus
Copy link
Member

@PartyWumpus PartyWumpus commented Oct 15, 2023

Please tick as appropriate:

  • I have tested this code on a steam deck or on a PC
  • My changes generate no new errors/warnings
  • This is a bugfix/hotfix
  • This is a new feature

If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/

Description

This fixes issue: #419

(This is currently waiting on SteamDeckHomebrew/decky-plugin-store#51 to be in the main plugin store so it actually works instead of just breaking sorting)
Adds four new options to the plugin store's sort box, release date ascending/descending and downloads asc/desc.

It also moves the Store.tsx page around a bit, so the tabs will load before the store does, and just display a spinner for the plugin list bit.

@PartyWumpus PartyWumpus marked this pull request as ready for review October 31, 2023 21:36
@PartyWumpus PartyWumpus self-assigned this Nov 11, 2023
@PartyWumpus PartyWumpus added the enhancement New feature or request label Nov 11, 2023
@ReanimationXP
Copy link

Please merge this, I really like to keep on top of what the newest plugins are or what has been updated. It would also be nice if the store would indicate if things are already installed and change the button text to "Update" rather than "Install". Would make browsing the store a lot less confusing.

@PartyWumpus
Copy link
Member Author

Please merge this.

To be honest, I totally forgot about this because I thought I already had... I'll finish it up and it should be good to merge soon.

It would also be nice if the store would indicate if things are already installed and change the button text to "Update" rather than "Install". Would make browsing the store a lot less confusing.

Yeah. I'm sure someone will get to it someday #360

@PartyWumpus PartyWumpus changed the title Add sorting by date to the plugin store Refactor plugin store and add sorting by downloads and release date Dec 19, 2023
@PartyWumpus
Copy link
Member Author

Alright should be done now.

@ReanimationXP
Copy link

Thank you!

Copy link
Member

@JohnnyCrazy JohnnyCrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

frontend/src/components/store/Store.tsx Show resolved Hide resolved
frontend/src/components/store/Store.tsx Show resolved Hide resolved
frontend/src/components/store/Store.tsx Show resolved Hide resolved
@PartyWumpus
Copy link
Member Author

PartyWumpus commented Feb 7, 2024

I've just noticed that the server is erroring when sorting by name (but not the other sorts). This shouldn't be merged until that is sorted.

@PartyWumpus
Copy link
Member Author

Okay, fixed that. This has been reviewed so i'm going to merge it.

@PartyWumpus PartyWumpus merged commit fd4ed81 into main Feb 7, 2024
12 checks passed
AAGaming00 pushed a commit that referenced this pull request Feb 14, 2024
…547)

* untested first commit

* fix types & names

* comment out built in sorting for now

* rerun search when sort changes

* fix ts complaints

* use prettier

* stop switch-case fall through

* move spinner

* use locale instead of hardcoded string

* fix typo

* add sorting by downloads & try using the data field in the dropdown for data

* fix typing error

* fix asc/desc in dropdown

* fix asc/desc again. asc = smaller one go first aaaaa

* I don't think i know what ascending means maybe

* use props instead of children, like a normal component
@PartyWumpus PartyWumpus deleted the better-sorting branch April 9, 2024 15:30
bricefriha pushed a commit to bricefriha/decky-loader that referenced this pull request Jun 3, 2024
…teamDeckHomebrew#547)

* untested first commit

* fix types & names

* comment out built in sorting for now

* rerun search when sort changes

* fix ts complaints

* use prettier

* stop switch-case fall through

* move spinner

* use locale instead of hardcoded string

* fix typo

* add sorting by downloads & try using the data field in the dropdown for data

* fix typing error

* fix asc/desc in dropdown

* fix asc/desc again. asc = smaller one go first aaaaa

* I don't think i know what ascending means maybe

* use props instead of children, like a normal component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants