-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call plugin unload function after stopping event loop #539
Merged
TrainDoctor
merged 1 commit into
SteamDeckHomebrew:main
from
Jan200101:PR/unload-after-eventloop
Dec 16, 2023
Merged
Call plugin unload function after stopping event loop #539
TrainDoctor
merged 1 commit into
SteamDeckHomebrew:main
from
Jan200101:PR/unload-after-eventloop
Dec 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can prevent race conditions where unload is clearing data but main is still working with it
Jan200101
force-pushed
the
PR/unload-after-eventloop
branch
from
November 5, 2023 14:28
be5fed0
to
77ce0ac
Compare
Going to give this a go. Apologies it took so long to get to this. |
TrainDoctor
approved these changes
Dec 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out on a local version and worked perfectly. Merged!
AAGaming00
pushed a commit
that referenced
this pull request
Dec 29, 2023
This can prevent race conditions where unload is clearing data but main is still working with it
PartyWumpus
added a commit
that referenced
this pull request
Feb 9, 2024
This reverts commit 39f4f28.
PartyWumpus
added a commit
that referenced
this pull request
Feb 9, 2024
AAGaming00
pushed a commit
that referenced
this pull request
Feb 14, 2024
bricefriha
pushed a commit
to bricefriha/decky-loader
that referenced
this pull request
Jun 3, 2024
…rew#539) This can prevent race conditions where unload is clearing data but main is still working with it
bricefriha
pushed a commit
to bricefriha/decky-loader
that referenced
this pull request
Jun 3, 2024
…eckHomebrew#539)" (SteamDeckHomebrew#584) This reverts commit 39f4f28 , because functions (seemingly) don't run after the event loop closes, so the unload function is never actually run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can prevent race conditions where unload is clearing data but main is still working with it
Please tick as appropriate:
If you're wanting to update a translation or add a new one, please use the weblate page: https://weblate.werwolv.net/projects/decky/
Description
During the unload long-running code is still active causing possible race conditions when unloads cleans up data which main was referencing.
Example Plugin