fix: letter spacing tokens were not being generated due to key not be… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing found in token name lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ing found in token name lookup
Converted number to string and added the unit (e.g. from 0 to '0em'). '0em' is the hash key needed to find the token name for the letterspacing (e.g., "standard"). Before fix it was just using 0 (as type number) and failing. This code fix also causes undefined or unmatched tokens to not be used in the semantic typography files rather than default them to "regular". Decided to trade-off some obscurity for having to alter the figmagic code if we want to rename a token.
Also removed some incorrect commented out code meant to assign color to the type stye.