Fix Missing Updates for Non-Simulator Builds #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supereg
reviewed
May 24, 2024
| @@ -40,15 +40,15 @@ class TimedWalkTestViewModel { | |||
| func requestPedemoterAccess() { | |||
| #if !targetEnvironment(simulator) | |||
There was a problem hiding this comment.
Wouldn’t a better solution be to move as much code out of the if compiler directive? E.g. have additional code for simulator at the start of the method and return before we reach the code executed on the life device. CoreMotion compiles in the simulator it just doesn’t do anything.
In essence: don’t exclude code using compiler directives (as best as possible) only use them to add additional code special to the simulator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Missing Updates for Non-Simulator Builds
⚙️ Release Notes
CC: Interesting situation here @vishnuravi & @Supereg. Our CI did not catch this error as we only build for simulator target. Might be interesting to explore how we could mitigate this in the future, e.g., also run an archive of the UITests application to run on the generic iOS target & test release builds at the same time?
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: