-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompose Nearby Device Row #18
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 83.11% 84.02% +0.92%
==========================================
Files 55 57 +2
Lines 2935 2934 -1
==========================================
+ Hits 2439 2465 +26
+ Misses 496 469 -27
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
Decompose Nearby Device Row
♻️ Current situation & Problem
The
NearbyDeviceRow
was a monolith-style view that encompassed all functionality without a lot of configuration possibilities to vitalizes a nearby device in, e.g., a Bluetooth scanning view. This design is not really flexible if you want to show your own information or want to adjust the layout. Previously you were forced to write your own view completely from scratch. This PR decomposes the view into multiple subview allowing you to build your customNearbyDeviceRow
-like experience without reinventing the wheel completely. The newPeripheralLabel
,PeripheralSecondaryLabel
, andInfoButton
views (see StanfordSpezi/SpeziViews#50) allow you to fully customize the appearance of yourNearbyDeviceRow
.⚙️ Release Notes
NearbyDeviceRow
intoPeripheralLabel
,PeripheralSecondaryLabel
, andInfoButton
views for greater customizability.📚 Documentation
Added new views to the DocC documentation target.
✅ Testing
The new tests are implicitly tested via the
NearbyDeviceRow
.📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: