Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primary color of nearby device row #16

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 25, 2024

Fix primary color of nearby device row

♻️ Current situation & Problem

Slight styling adjustments. Due to the button the device name was rendered in the accent color. This fixes the label to be primary color again.

⚙️ Release Notes

  • Fixed appearance of nearby device row.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.11%. Comparing base (85aee3d) to head (5dfeae6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   83.09%   83.11%   +0.02%     
==========================================
  Files          55       55              
  Lines        2933     2935       +2     
==========================================
+ Hits         2437     2439       +2     
  Misses        496      496              
Files with missing lines Coverage Δ
...icesUI/Measurements/ConfirmMeasurementButton.swift 100.00% <100.00%> (ø)
...rces/SpeziDevicesUI/Scanning/NearbyDeviceRow.swift 67.03% <100.00%> (+0.72%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85aee3d...5dfeae6. Read the comment docs.

@Supereg Supereg merged commit 397c0e8 into main Oct 25, 2024
8 checks passed
@Supereg Supereg deleted the fix/nearby-device-row-style branch October 25, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant