Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift to SpeziSpeech 1.0, NavigationBar item improvements #7

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Jan 19, 2024

Lift to SpeziSpeech 1.0, NavigationBar item improvements

♻️ Current situation & Problem

SpeziChat is still dependent on an old tagged version of SpeziSpeech.
In addition, the navigation bar share icon always allocates space (even when the icon is not shown - initially done for animation purposes), leading to issues with Views reusing the ChatView while adding navigation bar items.

⚙️ Release Notes

  • Lift SpeziChat to tagged 1.0.0 version of SpeziSpeech.
  • Adjust navigation bar item behaviour of export button

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Jan 19, 2024
@philippzagar philippzagar self-assigned this Jan 19, 2024
@philippzagar philippzagar changed the title Lift to SpeziSpeech 1.0.0 as well as NavigationBar item improvements Lift to SpeziSpeech 1.0 as well as NavigationBar item improvements Jan 19, 2024
@philippzagar philippzagar changed the title Lift to SpeziSpeech 1.0 as well as NavigationBar item improvements Lift to SpeziSpeech 1.0, NavigationBar item improvements Jan 19, 2024
@philippzagar philippzagar requested a review from Supereg January 19, 2024 22:24
Copy link
Member

@Supereg Supereg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating SpeziChat. Also good we simplified some of the ToolbarItem placement.

@philippzagar philippzagar enabled auto-merge (squash) January 19, 2024 23:08
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8817bf4) 82.93% compared to head (7f2da02) 82.86%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   82.93%   82.86%   -0.07%     
==========================================
  Files           9        9              
  Lines         451      449       -2     
==========================================
- Hits          374      372       -2     
  Misses         77       77              
Files Coverage Δ
Sources/SpeziChat/ChatView.swift 82.76% <100.00%> (-0.57%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8817bf4...7f2da02. Read the comment docs.

@philippzagar philippzagar merged commit 086ecb4 into main Jan 19, 2024
10 checks passed
@philippzagar philippzagar deleted the feat/lift-to-1.0 branch January 19, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants