Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LLM semantics from Chat models #14

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Conversation

philippzagar
Copy link
Member

Remove LLM semantics from Chat models

♻️ Current situation & Problem

As of now, SpeziChat contains some LLM semantics in the Chat and ChatEntity models. This mixes two different components that should live independent of each other.

⚙️ Release Notes

  • Remove LLM semantics from Chat models

📚 Documentation

Updates documentation

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Mar 23, 2024
@philippzagar philippzagar self-assigned this Mar 23, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.44%. Comparing base (2334583) to head (fb988f2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   84.87%   85.44%   +0.58%     
==========================================
  Files          13       14       +1     
  Lines         687      714      +27     
==========================================
+ Hits          583      610      +27     
  Misses        104      104              
Files Coverage Δ
Sources/SpeziChat/ChatView+Export.swift 72.03% <100.00%> (+1.23%) ⬆️
Sources/SpeziChat/ChatView+SpeechButton.swift 100.00% <ø> (ø)
Sources/SpeziChat/ChatView+SpeechOutput.swift 82.61% <100.00%> (+5.11%) ⬆️
Sources/SpeziChat/ChatView.swift 88.38% <100.00%> (+0.14%) ⬆️
Sources/SpeziChat/Helpers/TypingIndicator.swift 100.00% <100.00%> (ø)
Sources/SpeziChat/MessageInputView.swift 87.25% <ø> (ø)
...peziChat/Models/ChatEntity+HiddenMessageType.swift 100.00% <100.00%> (ø)
Sources/SpeziChat/Models/ChatEntity.swift 88.47% <100.00%> (-0.42%) ⬇️
Sources/SpeziChat/MessageView.swift 96.56% <92.86%> (-3.44%) ⬇️
Sources/SpeziChat/MessagesView.swift 89.48% <83.34%> (+0.29%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2334583...fb988f2. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @philippzagar; looks great to me! 🚀

@philippzagar philippzagar merged commit aaa10d7 into main Mar 26, 2024
18 checks passed
@philippzagar philippzagar deleted the feat/refactor-chat branch March 26, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants