Fix AccountSetup view ignoring all identity providers per section but one
#81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the last per section
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
- Coverage 83.95% 83.91% -0.03%
==========================================
Files 121 121
Lines 5256 5257 +1
==========================================
- Hits 4412 4411 -1
- Misses 844 846 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Supereg
approved these changes
Dec 15, 2024
…into lukas/identity-provider-sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
AccountSetupview ignoring all identity providers per section but one♻️ Current situation & Problem
Currently, the AccountSetupView groups the AccountService's
IdentityProviders by their section, to determine their order.As a result of this being implemented using a dictionary, with the providers as values, only the last provider per section is kept.
This means that, if an AccountService specifies multiple IdentityProviders for a section, most of them (all but one) will not be shown to the user.
⚙️ Release Notes
@IdentityProviders sometimes not being included in theAccountSetupview.📚 Documentation
n/a
✅ Testing
n/a
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: