Allow AccountSetup to be created with async function to handle completeness of the account setup

[pauljohanneskraft]

Allow AccountSetup to be created with async throwing function to handle completeness of the account setup

♻️ Current situation & Problem

When an account setup is successful, one may want to run additional code that is async and throwing to finish the account setup completely.

Specifically in ENGAGE-HF, we need to call a Firebase function when a new account has been created before the account can actually be used.

⚙️ Release Notes

• Allow setupComplete parameter in AccountSetup to be async-throwing.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[codecov]

Codecov Report

Attention: Patch coverage is 74.71264% with 44 lines in your changes missing coverage. Please review.

Project coverage is 83.23%. Comparing base (7ffb73d) to head (f082fa8).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...Account/Views/AccountSetup/AccountSetupState.swift	0.00%	35 Missing ⚠️
Sources/SpeziAccount/AccountSetup.swift	94.74%	3 Missing ⚠️
...Account/ViewModifier/AccountRequiredModifier.swift	81.25%	3 Missing ⚠️
Sources/SpeziAccount/Views/AccountSummaryBox.swift	91.67%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   83.79%   83.23%   -0.55%     
==========================================
  Files         122      121       -1     
  Lines        5204     5245      +41     
==========================================
+ Hits         4360     4365       +5     
- Misses        844      880      +36     

Files with missing lines	Coverage Δ
...ces/SpeziAccount/Environment/AccountViewType.swift	100.00% <ø> (ø)
...es/SpeziAccount/Environment/FollowUpBehavior.swift	50.00% <ø> (ø)
...s/SpeziAccount/Environment/PasswordFieldType.swift	95.00% <ø> (-1.15%)	⬇️
...SpeziAccount/Environment/PreferredSetupStyle.swift	100.00% <ø> (ø)
...Views/AccountSetup/DefaultAccountSetupHeader.swift	100.00% <100.00%> (ø)
...count/Views/AccountSetup/ExistingAccountView.swift	100.00% <100.00%> (ø)
...Account/Views/AccountSetup/FollowUpInfoSheet.swift	88.97% <100.00%> (+0.16%)	⬆️
Sources/SpeziAccount/Views/SignupFormHeader.swift	100.00% <100.00%> (ø)
Sources/SpeziAccount/AccountSetup.swift	91.42% <94.74%> (-0.66%)	⬇️
...Account/ViewModifier/AccountRequiredModifier.swift	87.10% <81.25%> (-3.28%)	⬇️
... and 2 more

... and 2 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ffb73d...f082fa8. Read the comment docs.

[Supereg]

Thanks for the great work 🚀

I think the PR is generally in a good shape. Just had a few comments and ideas that discusses some of the detailed design of this PR.

[pauljohanneskraft]

I reverted the changes that are needed in ENGAGE-HF and will open a different PR instead, since this might still be a nice addition, but actually isn't needed urgently anymore.

Feel free to keep this open / ask for adaptions though!

[PSchmiedmayer]

Thank you for the work here @pauljohanneskraft! I had a comment about the API surface were we could improve the naming; apart from this the change looks good and once @Supereg's comment are addressed we can merge this as a nicer generalization of this feature.

[PSchmiedmayer]

Thank you for the updates @pauljohanneskraft!

@Supereg feel free to provide a last review and merge the PR before we tag a next major version.

[Supereg]

Hey, sorry for the delay here. The PR is in a very good shape. Great work 🚀 I only had some smaller comments.

[Supereg]

To save you some context switches and time, I went forward and quickly incorporated the changes I had in my comments and rebased onto the latest changes from main. I noticed that in your implementation the loadingExistingAccount was never actually set anymore. I fixed that and merged that state with the isCompletingSetup state you introduced. I used this step to also polish the AccountSetupState implementation a bit and fully exposed it, replacing the previous underscore implementation.
Hope that works and feel free to merge the PR if you are happy with the changes. We can release these as 2.1.0 then 👍

[PSchmiedmayer]

Amazing; thank you @Supereg!

Feel free to merge the PR if it looks good to you @pauljohanneskraft 🚀

[pauljohanneskraft]

Looks good to me in general, just two minor comments that may be irrelevant - let me know what you think 😊 otherwise I'd be happy to merge, especially that new @Entry API looks really nice 🎉