Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic type sizes and longer timeout for required account modifier #51

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Feb 20, 2024

Support dynamic type sizes and longer timeout for required account modifier

♻️ Current situation & Problem

Currently, the accountRequired modifier provides 500ms for account details to be available, before it brings up the Account Sheet to enforce an account login. This time is to shorts and currently makes the Account Sheet pop up after fresh app starts for a few milliseconds. We increase the timeout to be more lenient.

Further, this PR addresses #50 by using the new ListRow and DynamicHStack views for all list row contents optimizing SpeziAccount for larger dynamic type sizes.

⚙️ Release Notes

  • Fixed an issue where the account required sheet was popping up to early.
  • Optimize UI for larger dynamic type sizes.

📚 Documentation

--

✅ Testing

--

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (714f01a) 76.03% compared to head (fc196fa) 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #51       +/-   ##
==========================================
- Coverage   76.03%   0.00%   -76.02%     
==========================================
  Files         117     116        -1     
  Lines        4016    4002       -14     
==========================================
- Hits         3053       0     -3053     
- Misses        963    4002     +3039     
Files Coverage Δ
...peziAccount/AccountValue/Keys/DateOfBirthKey.swift 0.00% <0.00%> (-87.50%) ⬇️
...SpeziAccount/AccountValue/Keys/PersonNameKey.swift 0.00% <0.00%> (-94.82%) ⬇️
...ces/SpeziAccount/AccountValue/Keys/UserIdKey.swift 0.00% <0.00%> (-83.33%) ⬇️
...Account/ViewModifier/AccountRequiredModifier.swift 0.00% <0.00%> (-96.66%) ⬇️
...ataDisplay/LocalizableStringBasedDisplayView.swift 0.00% <0.00%> (-57.14%) ⬇️
...unt/Views/DataDisplay/StringBasedDisplayView.swift 0.00% <0.00%> (-72.72%) ⬇️
Sources/SpeziAccount/Views/SignupForm.swift 0.00% <0.00%> (-89.25%) ⬇️
...eziAccount/Views/Fields/GenderIdentityPicker.swift 0.00% <0.00%> (-53.12%) ⬇️
.../SpeziAccount/Views/Fields/DateOfBirthPicker.swift 0.00% <0.00%> (-70.10%) ⬇️

... and 93 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 714f01a...fc196fa. Read the comment docs.

@Supereg Supereg requested a review from philippzagar February 20, 2024 20:54
Copy link
Member

@philippzagar philippzagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great to see all the accessibility functionalities! 🚀

@Supereg Supereg enabled auto-merge (squash) February 20, 2024 21:01
@Supereg Supereg disabled auto-merge February 20, 2024 22:38
@Supereg Supereg merged commit 1ced521 into main Feb 20, 2024
7 of 9 checks passed
@Supereg Supereg deleted the feature/dynamic-type-sizes branch February 20, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants