Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize for dynamic type sizes #50

Open
1 task done
Supereg opened this issue Feb 20, 2024 · 0 comments
Open
1 task done

Optimize for dynamic type sizes #50

Supereg opened this issue Feb 20, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Supereg
Copy link
Member

Supereg commented Feb 20, 2024

Problem

SpeziAccount is currently optimized to work well with accessibility infrastructure like Voice Over. However, it is not optimized for larger screens or to work well with dynamic type sizes.

Solution

We need to update SpeziAccount UI to accommodate for dynamic type sizes. The new ListRow and DynamicHStack views might be helpful here for all List-based layouts.

This PR might also tackle adjusting the interface for visionOS-based apps, see #14.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the enhancement New feature or request label Feb 20, 2024
@Supereg Supereg changed the title Optimiere for dynamic type sizes Optimize for dynamic type sizes Feb 20, 2024
Supereg added a commit that referenced this issue Feb 20, 2024
…difier (#51)

# Support dynamic type sizes and longer timeout for required account
modifier

## ♻️ Current situation & Problem
Currently, the `accountRequired` modifier provides 500ms for account
details to be available, before it brings up the Account Sheet to
enforce an account login. This time is to shorts and currently makes the
Account Sheet pop up after fresh app starts for a few milliseconds. We
increase the timeout to be more lenient.

Further, this PR addresses #50 by using the new `ListRow` and
`DynamicHStack` views for all list row contents optimizing SpeziAccount
for larger dynamic type sizes.

## ⚙️ Release Notes 
* Fixed an issue where the account required sheet was popping up to
early.
* Optimize UI for larger dynamic type sizes.


## 📚 Documentation
--


## ✅ Testing
--


## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
@PSchmiedmayer PSchmiedmayer moved this to Backlog in Project Planning Feb 22, 2024
@PSchmiedmayer PSchmiedmayer added the good first issue Good for newcomers label Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants