Sundry fixes #865
Sundry fixes #865
Conversation
| @@ -21,6 +26,17 @@ import {ArticlesNavManualList} from '~/components/ArticlesNav/ArticleNavManualLi | |||
| export const LINK_WITHOUT_DETAILS_CLS = 'link-without-details' | |||
|
|
|||
| export const loader = async ({request, params}: LoaderFunctionArgs) => { | |||
| const {data: redirects} = await loadRedirects(request) | |||
|
|
|||
| // Check if we need to redirect to a new path | |||
There was a problem hiding this comment.
/questions/<page id> redirects weren't working, because they were being caught by this route and rendered as normal questions
There was a problem hiding this comment.
https://aisafety.info/questions/8TJV/How-can-I-help
now renders as "deleted", but the redirection is not working (see https://coda.io/d/AI-Safety-Info_dfau7sl2hmG/Redirects_suCc9XjM#Redirects_tuDQLOm3)
This is a local improvement over the previous situation, but I'd still rather redirections take priority over deleted articles
There was a problem hiding this comment.
It seems like all redirections now fail, https://aisafety.info/help won't resolve either
| @@ -163,6 +179,8 @@ export default function RenderArticle() { | |||
| return ( | |||
| <Error error={{statusText: 'Could not fetch question', status: 'emptyArticle'}} /> | |||
| ) | |||
| } else if (resolvedQuestion.data.status === QuestionStatus.TO_DELETE) { | |||
There was a problem hiding this comment.
any other states that should display errors?
There was a problem hiding this comment.
Duplicate
They are used essentially in the same way, they can both have the same error msg.
| ({tags, status}) => | ||
| tags?.includes(INTRODUCTORY) || | ||
| tags?.includes(ADVANCED) || | ||
| status === QuestionStatus.SUBSECTION |
There was a problem hiding this comment.
this could mess up things - if a subsection isn't tagged as introductory or advanced then it may show up somewhere it shouldn't. This seemed like the simplest way to do it, though
There was a problem hiding this comment.
Subsections are actually never tagged as either introductory or advanced, only sections are tagged as such. Still, I think the code makes sense. Did you mean that weird things will happen if a subsection is tagged as introductory or advanced?
There was a problem hiding this comment.
I don't know if they will happen, but I'm not certain that they won't...
|
why are the tests failing... :/ |
|
aha. Npm is having problems... |
/question/<pageid>redirects