Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css fixes for various screen sizes and page loading #599

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

Aprillion
Copy link
Collaborator

@Aprillion Aprillion commented Apr 28, 2024

Copy link
Contributor

@melissasamworth melissasamworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to be overdramatic but... You are my hero.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha what is .fcol-5?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added body {max-width: ...} to improve wide screen experience, so the .col-x {width: ...vw} classes didn't make sense any more so I replaced them with .fcol-x {flex: x} for now as a workaround until someone figures out how to implement the design system in a way that will work for all screen sizes

@melissasamworth melissasamworth merged commit 6f2a69d into master Apr 30, 2024
1 check failed
@melissasamworth melissasamworth deleted the sidebar-fix branch April 30, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants