Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy test env #408

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Deploy test env #408

merged 2 commits into from
Feb 15, 2024

Conversation

mruwnik
Copy link
Collaborator

@mruwnik mruwnik commented Feb 15, 2024

I'm not sure how to best deploy a test version of the new site, so please criticize this

.github/workflows/deploy-dev.yml Show resolved Hide resolved
- name: Deploy to Cloudflare
run: |
cat wrangler.toml.template \
| sed s/stampy-ui/redesign/ \
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this suffice for it to not overwrite the current page?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea 🤷

Copy link
Collaborator

@Aprillion Aprillion Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I created 2 new GH secrets if you want to replace next 2 lines to be on the safe side 😅

then you can try that https://stampy-ui.aprillion.workers.dev/ is the version from my manual deploy last week vs https://redesign.aprillion.workers.dev/ would be created from this action (feel free to add some version indicator, e.g. console log git commit date or something, if it would be hard to spot a difference)

CLOUDFLARE_ACCT_ID_APRILLION_WORKERS_DEV
STAMPY_KV_ID_APRILLION_WORKERS_DEV

let me know if there are more steps to enable something somewhere to allow deploy from GH action in my CF account that I forgot about

@mruwnik mruwnik requested a review from Aprillion February 15, 2024 15:11
@Aprillion Aprillion requested a review from jrhender February 15, 2024 15:38
Copy link
Collaborator

@jrhender jrhender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mruwnik mruwnik merged commit 39aa785 into master Feb 15, 2024
1 check passed
@mruwnik mruwnik deleted the deploy-dev branch February 15, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants