Update dependencies #1009
Merged
Update dependencies #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
arm4b
suggested changes
Oct 21, 2023
There was a problem hiding this comment.
Thanks a lot!
Could you please update the https://github.com/StackStorm/st2web/blob/master/CHANGELOG.rst as well?
Besides that, all good.
A note for myself before merging: I'll probably need to do a quick st2web visual check to make sure nothing broke because of updates.
arm4b
reviewed
Oct 21, 2023
arm4b
approved these changes
Oct 21, 2023
13 tasks
Kami
approved these changes
Oct 21, 2023
|
@Kami welcome to the party! 🎉 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates softer defined \ transient dependencies and is supposed to cover for a number of open dependabot PRs in one feel swoop.
Three minor issues discovered:
content-typeto be populated. Instead, it now sends the value provided in thedatafield verbatim and breaks auth flow. Removing previous hack fixes the problem.fontello-update's dependencyopenhas been defined very broadly and as>=6.0.0and switched to ESM starting 9.0.0. We do not use ESM on this project and it isn't worth to start because of a single transient dependency.ST2_PROTOCOLwe forgot to add it to ourservetask. This creates a problem when you trying to run local version of st2web against dockerized st2.In general, I have to admit, I'm beyond impressed with how well this project held up for all this years with minimal maintenance it had. Thanks to the community for keeping it afloat.