Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Version check evaluator #205

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

AkashS0510
Copy link
Collaborator

Pull Request Template

Description

  • What changes are being made?

    • Added VersionCompare evaluator, a utility to compare version strings (e.g., 1.0.0 vs 1.2.0) and provide evaluation results.
  • Why are these changes necessary?

    • This feature is crucial for applications requiring accurate comparison of version strings.
  • Which issues or tickets does this PR close or relate to?

    • Related issue: #

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Other (please specify):

Checklist

  • Code has been linted.
  • Documentation has been updated (if needed).
  • Tests have been added or updated (if needed).
  • Any breaking changes have been communicated to the team.

Screenshots or Recordings (if applicable)

Additional Information

Copy link

@@ -33,7 +33,10 @@ def generate_evaluator_result(evaluator_obj, input_data, provider_module):
provider_inputs = evaluator_obj.get("provider_args")
condition = evaluator_obj.get("condition")
evaluator_name: str = condition.get("type")
evaluator_data = condition.get("value")
if evaluator_name is "VersionCompare":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make core as agnostic as possible towards the available condition types so that it's loosely coupled

Will discus this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants