Simplify Type Checking in sort_collections Function #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrilito1
requested review from
Akshat0694,
arunim2405 and
refeed
as code owners
AkashS0510
previously approved these changes
Sep 30, 2024
|
@gabrilito1 Can you squash the commits into a single one? |
|
@gabrilito1 Can you also correct the linting issue? |
|
@gabrilito1 You have made the commit e3867d7 outside of this branch. Instead Can you commit the changes in this branch? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify type checking in sort_collections Function, closing #185