Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error Messages with Extra Closing Parentheses closes #182 #184

Closed
wants to merge 2 commits into from

Conversation

zafar-hussain
Copy link

Hi,

This PR closes #182,

Extra Closing Parentheses were removed from 4 points in handler.py and 1 in test_direct_references.py

cheers

Copy link

@zafar-hussain zafar-hussain marked this pull request as draft September 27, 2024 13:59
@AkashS0510 AkashS0510 self-requested a review September 28, 2024 09:57
@AkashS0510
Copy link
Collaborator

Thanks for the PR @zafar-hussain . Can you squash the commits into a single one and put a commit description about the changes you made?

@zafar-hussain
Copy link
Author

Hi @AkashS0510

Thanks for the reply,

Mistakenly, I have pushed two separate commits together, first one was for issue #182 and the second (incorrectly included) was meant for issue #180

I am failing in finding a way to undo it.

Please, if you can guide me to cancel this PR, or remove the second commit

I will push separate PRs again

thanks
zafar

@AkashS0510
Copy link
Collaborator

@zafar-hussain Maybe you can close this PR and create 2 new PRs from 2 different branches for the two issues.

@zafar-hussain
Copy link
Author

Wrong commits merged together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Fix Error Messages with Extra Closing Parentheses
2 participants