Resolved Issue - Update logger initialization to use module-specific loggers #140 #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samriddhi99
suggested changes
Jul 24, 2024
|
Have removed the TODO comments |
refeed
reviewed
Jul 25, 2024
AkashS0510
force-pushed
the
update-logger
branch
4 times, most recently
from
bdcb4f4 to
acf1fdb
Compare
refeed
requested changes
Jul 29, 2024
AkashS0510
force-pushed
the
update-logger
branch
2 times, most recently
from
3644714 to
3ca22bf
Compare
|
Close and reopening the PR to trigger gh actions |
samriddhi99
approved these changes
Jul 29, 2024
Changed "logger = logging.getLogger()" line of code to "logger = logging.getLogger(__name__)" in all files Removed the TODO Comments - "# TODO: At least add __name__ as the name for the logger" in all files #140
samriddhi99
force-pushed
the
update-logger
branch
from
62fbaa7 to
10ea326
Compare
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed logger = logging.getLogger() to logger = logging.getLogger(name) in all files #140