Returns error code 1 when final result is False #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refeed
approved these changes
Jul 10, 2024
samriddhi99
force-pushed
the
fix_error_code
branch
from
045c929 to
4fc68b7
Compare
samriddhi99
force-pushed
the
fix_error_code
branch
from
4fc68b7 to
adcc425
Compare
samriddhi99
force-pushed
the
fix_error_code
branch
from
adcc425 to
2b1ccca
Compare
|
Akshat0694
reviewed
Sep 3, 2024
| @@ -118,6 +118,10 @@ def __init__(self, prog="PROG") -> None: | |||
| print(formatted_result) | |||
| else: | |||
| pretty_print_result_dict(result) | |||
|
|
|||
There was a problem hiding this comment.
@refeed can you please verify how this will impact the current terraform workflow step and if we are using the exit code correctly.
There was a problem hiding this comment.
@samriddhi99 here is my proposal for the exist codes: #173
Let us please implement in this PR itself.
|
@samriddhi99 need followup, please let me know when you are available |
|
Closing this as @samriddhi99 is not available in the meantime. But can be reopened later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #89