Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Add Type Annotations #180

Open
AkashS0510 opened this issue Sep 21, 2024 · 5 comments
Open

🚀 Add Type Annotations #180

AkashS0510 opened this issue Sep 21, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@AkashS0510
Copy link
Collaborator

Issue: Several functions lack type annotations. Adding type hints can improve code readability and help with static type checking.

Solution: Go through the handler.py of all providers ( infracost, json, kubernetes, sg_workflow, terraform_plan ) and add type hints to functions .

Example:

def _get_exp_attribute(split_expressions: List[str], input_data: dict) -> List[Any]:

@AkashS0510 AkashS0510 added the enhancement New feature or request label Sep 21, 2024
@refeed refeed added good first issue Good for newcomers enhancement New feature or request and removed enhancement New feature or request labels Sep 23, 2024
@zafar-hussain
Copy link

Please assign the issue to me,

cheers

@AkashS0510
Copy link
Collaborator Author

@zafar-hussain Sure, I have assigned it to you.

@kushal9897
Copy link

I would like to work on this

@zafar-hussain
Copy link

@zafar-hussain Sure, I have assigned it to you.

@AkashS0510 . Please do assign this issue to another applicant

cheers

@AkashS0510
Copy link
Collaborator Author

@kushal9897 assigning it to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants