Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skesa has actually had a new version for awhile, I just didn't notice because of their tag. It looks like I wasn't the only one confused (ncbi/SKESA#39).
Closes #748
To add to the confusion or reduce the confusion, I vote we tag this image as skesa.2.4.0_saute.1.3.0_2, which is the same tag as their github repo. It's actually for skesa version 2.5.1 - which I guess we could use as well. (Does that mean we would tag this as skesa.2.4.0_saute.1.3.0_2, 2.5.1, and latest?)
I completely changed things from the prior Dockerfile. I added a builder, app, and test stage, CMD line, and some tests. I also added a tool-specific readme where it lists the versions of all the tools installed.
I opted to not use the pre-compiled executables because their url changes too much (i.e. https://github.com/ncbi/SKESA/releases/download/skesa.2.4.0_saute.1.3.0_2/gfa_connector.centos.7.9.2009 and https://github.com/ncbi/SKESA/releases/download/2.4.0/gfa_connector.centos7.7), which is why I put together the builder stage.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)