-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revamping artic with updated medaka #723
Conversation
Sorry! Since I'm downloading files from the ENA, I can't test my 'test' locally. I'll fix this in gitpod and then convert this from draft stage. |
@kevinlibuit , I hope you have time to review this image. It's now ready for review (I had some typos in the test layer that I needed to resolve). Once I finish this image, I'm going to apply the same ideas to the artic-ncov2019-epi2me Dockerfile (#689) |
@kevinlibuit , does this look like it would work? |
Will test our workflows using the UPHL's identical docker on quay to ensure things aren't breaking in any of our workflows: |
There's a current version of this on UPHL's quay repo : quay.io/uphl/artic tag 1.2.4-1.9.4-1 |
Will also need to test availabilities of updated models, e.g. |
@kevinlibuit , medaka has gone through a few updates recently, so I've updated the Dockerfile to use the most recent version of medaka. The readme now lists all the supported models for medaka, or did you have something else in mind? There's a current version of this image at quay.io/uphl/artic tag 1.2.4-1.11.1 |
@kevinlibuit , do you have time to review this? |
Apologies for the delay! Tested this both locally and used the uphl quay image to ensure no issues with our workflows on Terra. Thanks, also, for adding info on available models. |
Accidentally closed! |
This is a new container with the most-current artic and medaka versions. I've also finally added artic to the licenses.
Both of these tools' bioconda packages lag significantly, and I'd like the current medaka models.
I've changed the directory structure of this image. It's now
I would like the tag to also follow the pattern of ${artic_version}-${medaka_version}, so this one would be tagged
1.2.4-1.9.1
.I have not included any primers in this. It's already fairly large and my use-case is with non-artic primers at the moment anyway.
Lastly, in a future PR, I'd like to move the old artic* files into /artic for cleanliness purposes.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15
)spades/3.12.0/Dockerfile
)shigatyper/2.0.1/test.sh
)spades/3.12.0/README.md
)