Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamping artic with updated medaka #723

Merged
merged 11 commits into from
Nov 9, 2023
Merged

revamping artic with updated medaka #723

merged 11 commits into from
Nov 9, 2023

Conversation

erinyoung
Copy link
Contributor

This is a new container with the most-current artic and medaka versions. I've also finally added artic to the licenses.

Both of these tools' bioconda packages lag significantly, and I'd like the current medaka models.

I've changed the directory structure of this image. It's now

artic/${artic_version}-${medaka_version}/

I would like the tag to also follow the pattern of ${artic_version}-${medaka_version}, so this one would be tagged 1.2.4-1.9.1.

I have not included any primers in this. It's already fairly large and my use-case is with non-artic primers at the moment anyway.

Lastly, in a future PR, I'd like to move the old artic* files into /artic for cleanliness purposes.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung erinyoung marked this pull request as draft September 1, 2023 22:50
@erinyoung
Copy link
Contributor Author

Sorry! Since I'm downloading files from the ENA, I can't test my 'test' locally. I'll fix this in gitpod and then convert this from draft stage.

@erinyoung erinyoung marked this pull request as ready for review September 6, 2023 19:04
@erinyoung
Copy link
Contributor Author

@kevinlibuit , I hope you have time to review this image. It's now ready for review (I had some typos in the test layer that I needed to resolve).

Once I finish this image, I'm going to apply the same ideas to the artic-ncov2019-epi2me Dockerfile (#689)

@erinyoung
Copy link
Contributor Author

@kevinlibuit , does this look like it would work?

@kevinlibuit
Copy link
Contributor

Will test our workflows using the UPHL's identical docker on quay to ensure things aren't breaking in any of our workflows:

@erinyoung
Copy link
Contributor Author

There's a current version of this on UPHL's quay repo : quay.io/uphl/artic tag 1.2.4-1.9.4-1

@kevinlibuit
Copy link
Contributor

kevinlibuit commented Oct 12, 2023

Will also need to test availabilities of updated models, e.g. r103_hac_g507

@erinyoung
Copy link
Contributor Author

@kevinlibuit , medaka has gone through a few updates recently, so I've updated the Dockerfile to use the most recent version of medaka.

The readme now lists all the supported models for medaka, or did you have something else in mind?

There's a current version of this image at quay.io/uphl/artic tag 1.2.4-1.11.1

@erinyoung
Copy link
Contributor Author

@kevinlibuit , do you have time to review this?

@kevinlibuit
Copy link
Contributor

Apologies for the delay! Tested this both locally and used the uphl quay image to ensure no issues with our workflows on Terra. Thanks, also, for adding info on available models.

@kevinlibuit kevinlibuit closed this Nov 9, 2023
@kevinlibuit kevinlibuit reopened this Nov 9, 2023
@kevinlibuit
Copy link
Contributor

Accidentally closed!

@kevinlibuit kevinlibuit merged commit e361034 into master Nov 9, 2023
4 checks passed
@erinyoung erinyoung deleted the erin-update-artic branch November 9, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants