[CHORE] Refacto logger #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 11, 2024 20:33
…e shell commands The code was drastically refactored for project restructuring. The directory "integrations" was renamed to "modules" to make the purpose clearer. Ansible shell-related codes have been managed and encapsulated into the AnsibleShellCommandsManager class under the shell managers module. This redesign aimed to improve the readability and maintainability of the code.
# Conflicts: # server/src/core/startup/index.ts
In this commit, several changes have been made including the refactoring of module imports and naming structures, choosing more descriptive names for loggers and changing messages sent to logger for clarity. Methods within classes have also been renamed to provide a clearer understanding of their functions. A method to delete automations has been added.
This commit moves the api error handlers from core to middlewares. It also eliminates logger information from automation, settings, playbook services and more. These changes align with our aim to streamline codebase and improve the application's overall maintainability.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
server/src/modules/shell/managers/AnsibleShellCommandsManager.ts
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.