Feat playbooks git sync #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored playbook management and execution functionalities in the system. Essential changes include renaming "ansible" routes to "playbook" routes, relocating several playbook related files, and modifying ansible related Python scripts. Added functionality to filter results by file extensions in directory tree listing and created a REST service for managing playbook repositories.
Refactored playbook management and execution functionalities in the system. Essential changes include renaming "ansible" routes to "playbook" routes, relocating several playbook related files, and modifying ansible related Python scripts. Added functionality to filter results by file extensions in directory tree listing and created a REST service for managing playbook repositories.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 2 commits
June 30, 2024 14:02
The documentation files previously suggested using the 'playbooks-repository clone' command to copy the repositories. These instructions have been updated to use the more standard 'git clone' command instead, providing more general compatibility.
…at-playbooks-git-sync
added 6 commits
June 30, 2024 16:54
The server integrations and use-cases have been updated for improved efficiency and clarity. The `syncToRepository` method was removed from multiple components for redundancy. The handling of asynchronous calls and data manipulation methods was modified as well. New test files were added to verify tree-utils functionality and the `PlaybookRepositoryComponent`.
The term 'playbooks' has been replaced with 'ansible' in multiple locations across the codebase - both in commands and in actual code. This clarifies the usage and the relevance of Ansible in areas such as the AnsibleGalaxyCommand, in shell commands, and in cache interactions. Even in the technical documentation and guide, references have been updated to reflect this change.
The documentation has been updated to replace incorrect references of 'playbooks-repository' with the correct 'git' command. Additionally, an icon source in the main site page was replaced to better reflect the compatibility with Ansible. These changes ensure that users are provided with accurate instructions and consistent visual cues.
The documentation has been updated to replace incorrect references of 'playbooks-repository' with the correct 'git' command. Additionally, an icon source in the main site page was replaced to better reflect the compatibility with Ansible. These changes ensure that users are provided with accurate instructions and consistent visual cues.
The contribute guide has been updated to include an explicit step for creating a new branch for changes. This clarification ensures contributors understand the importance of not making changes directly on the main branch.
Codebase has been refactored to break down shell operations pertaining to playbooks, files, and repositories. Export structure has been improved and segment separation helps identify which components are responsible for each task. While enhancing code readability, this also facilitates future code maintenance and improvements.
| async function saveSshKey(key: string, uuid: string) { | ||
| try { | ||
| logger.info('[SHELL] - vaultSshKey Starting...'); | ||
| if (shell.exec(`echo '${key}' > /tmp/${uuid}.key`).code !== 0) { |
Check failure
Code scanning / CodeQL
Uncontrolled command line Critical
| async function newPlaybook(fullFilePath: string) { | ||
| try { | ||
| logger.info('[SHELL] - newPlaybook - Starting...'); | ||
| shell.touch(fullFilePath); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if (fileExist) { | ||
| throw new Error('Directory or file already exists'); | ||
| } | ||
| return shell.mkdir('-p', fullPath); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| throw new Error('Attempt to delete a file or directory outside the root directory'); | ||
| } | ||
| } | ||
| shell.rm('-rf', directory); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
added 2 commits
July 1, 2024 13:46
This commit introduces substantial updates across several different files. Changes include aligning directory paths with updated UUIDs, integrating migration instructions with Scheme version tracking, improving Shell methods imports, standardising tree building across several components, ensuring unique name for Playbook model, and modifying Git commit messages to reflect updates through SSM. The updates aim to improve functionality, increase efficiency, and fix previous issues.
Adjusted the function call to install an Ansible Galaxy Collection in the galaxy.ts file. The updated version adds a necessary layer to the function call (`AnsibleShell`) ensuring the correct execution of the installAnsibleGalaxyCollection method.
| async function installAnsibleGalaxyCollection(name: string, namespace: string) { | ||
| try { | ||
| logger.info('[SHELL] - installAnsibleGalaxyCollection Starting...'); | ||
| const result = shell.exec(AnsibleGalaxyCmd.getInstallCollectionCmd(name, namespace)); |
Check failure
Code scanning / CodeQL
Uncontrolled command line Critical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.