Merge pull request #536 from SquirrelCorporation/bug-fix-popover-for-…

…repo-errors [BUG] Remove unnecessary popover styling and extend error handling
SquirrelCorporation · Nov 29, 2024 · c2c746e · c2c746e
2 parents cf4e9d6 + 7801287
commit c2c746e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 10 deletions.
diff --git a/client/src/pages/Admin/Settings/components/ContainerStacksSettings.tsx b/client/src/pages/Admin/Settings/components/ContainerStacksSettings.tsx
@@ -130,11 +130,6 @@ const ContainerStacksSettings: React.FC = () => {
                 if (row.onError) {
                   return (
                     <Popover
-                      overlayStyle={{
-                        width: '400px',
-                        height: '400px',
-                        overflowY: 'scroll',
-                      }}
                       content={
                         <Space direction="vertical" size={'small'}>
                           <Typography.Text>

diff --git a/client/src/pages/Admin/Settings/components/PlaybooksSettings.tsx b/client/src/pages/Admin/Settings/components/PlaybooksSettings.tsx
@@ -327,11 +327,6 @@ const PlaybookSettings: React.FC = () => {
                 if (row.onError) {
                   return (
                     <Popover
-                      overlayStyle={{
-                        width: '400px',
-                        height: '400px',
-                        overflowY: 'scroll',
-                      }}
                       content={
                         <Space direction="vertical" size={'small'}>
                           <Typography.Text>

diff --git a/shared-lib/src/types/api.ts b/shared-lib/src/types/api.ts
@@ -669,6 +669,8 @@ export type GitPlaybooksRepository = PlaybooksRepository & {
   default: boolean;
   gitService: Services;
   accessToken?: string;
+  onError?: boolean;
+  onErrorMessage?: string;
 }
 
 export type LocalPlaybooksRepository = PlaybooksRepository & {