Add tests and error handling for ExtraVarsTransformer

In this commit, tests have been added for the ExtraVarsTransformer function to ensure proper functioning and error handling. The function now includes a try-catch block to manage potential errors during the transformation of extraVars. In addition, import statements in the ExtraVars.test.ts file have been rearranged.

server/src/integrations/ansible/utils/ExtraVarsTransformer.ts

@@ -2,15 +2,19 @@ import { API } from 'ssm-shared-lib';
 import logger from '../../../logger';
 
 function transformExtraVars(extraVars: API.ExtraVars) {
-  const stringifyObject = extraVars
-    .map((e) => {
-      return `"${e.extraVar}": "${e.value}"`;
-    })
-    .reduce((previousValue, currentValue) => {
-      return previousValue + ',' + currentValue;
-    });
-  logger.debug(stringifyObject);
-  return JSON.parse('{' + stringifyObject + '}');
+  try {
+    const stringifyObject = extraVars
+      .map((e) => {
+        return `"${e.extraVar}": "${e.value}"`;
+      })
+      .reduce((previousValue, currentValue) => {
+        return previousValue + ',' + currentValue;
+      });
+    logger.debug(stringifyObject);
+    return JSON.parse('{' + stringifyObject + '}');
+  } catch (error: any) {
+    throw new Error('Error during transformExtraVars');
+  }
 }
 
 export default {

server/src/tests/integrations/ansible/ExtraVars.test.ts

@@ -1,4 +1,4 @@
-import { test, vi, expect, describe } from 'vitest';
+import { describe, expect, test, vi } from 'vitest';
 import extraVarsOps from '../../../integrations/ansible/utils/ExtraVars';
 
 describe('test ExtraVars', () => {

server/src/tests/integrations/ansible/ExtraVarsTransformer.test.ts

@@ -0,0 +1,59 @@
+import { describe, expect, test } from 'vitest';
+import { API } from 'ssm-shared-lib';
+import ExtraVarsTransformer from '../../../integrations/ansible/utils/ExtraVarsTransformer';
+
+describe('transformExtraVars function', () => {
+  test('should transform list of extraVars into object correctly', () => {
+    const input: API.ExtraVar[] = [
+      { extraVar: 'var1', value: 'value1' },
+      { extraVar: 'var2', value: 'value2' },
+      { extraVar: 'var3', value: 'value3' },
+    ];
+    const result = ExtraVarsTransformer.transformExtraVars(input);
+    expect(result).toEqual({
+      var1: 'value1',
+      var2: 'value2',
+      var3: 'value3',
+    });
+  });
+
+  test('empty input', () => {
+    const input: API.ExtraVar[] = [];
+    expect(() => ExtraVarsTransformer.transformExtraVars(input)).toThrow(
+      'Error during transformExtraVars',
+    );
+  });
+
+  test('should handle missing value field in extraVar', () => {
+    const input: API.ExtraVar[] = [{ extraVar: 'var1', value: 'value1' }, { extraVar: 'var2' }];
+    const result = ExtraVarsTransformer.transformExtraVars(input);
+    expect(result).toEqual({
+      var1: 'value1',
+      var2: 'undefined',
+    });
+  });
+
+  test('should handle missing extraVar field', () => {
+    // @ts-expect-error incorrect typing test
+    const input: API.ExtraVar[] = [{ value: 'value1' }, { extraVar: 'var2', value: 'value2' }];
+    const result = ExtraVarsTransformer.transformExtraVars(input);
+    expect(result).toEqual({
+      undefined: 'value1',
+      var2: 'value2',
+    });
+  });
+
+  test('undefined input', () => {
+    // @ts-expect-error incorrect typing test
+    expect(() => ExtraVarsTransformer.transformExtraVars(undefined)).toThrow(
+      'Error during transformExtraVars',
+    );
+  });
+
+  test('null input', () => {
+    // @ts-expect-error incorrect typing test
+    expect(() => ExtraVarsTransformer.transformExtraVars(null)).toThrow(
+      'Error during transformExtraVars',
+    );
+  });
+});