Removed decoding step and activate decoding by client #2
Conversation
environment:
Error MessageTried i2 on the mirror image: Tracing the error put me in this part of code: |
|
I had |
| output = generator.__next__() | ||
| except docker.errors.APIError as error: | ||
| raise docker.errors.BuildError(reason=error.explanation, build_log=error) | ||
|
|
||
| output = json.loads(output.decode()) | ||
|
|
||
| # Setup progress bar | ||
| num_steps = int(output["stream"].split()[1].split("/")[-1]) |
There was a problem hiding this comment.
This will not work because we need the output to determine the number of steps.
Case like this (b'{"stream":"\\n"}\r\n') happend lot of times during the build, just ignore with something like:
output = json.loads(output.decode().split("\n")[0])Maybe add this to the other place where we decode the docker output if it happend at all step.
There was a problem hiding this comment.
I think the pattern is not regular, sometimes there is a lot of /n before the content we want. but I will try ur solution nevertheless
FIX
There was an issue when decoding the docker logs with the json package on @bibs2091 's machine. Removing the two-step decoding and adding the
decodeargument to theclient.build()call seems to fix the issue.Additional context
@bibs2091 please add screenshots and error logs as well as your hardware, OS and software versions for everything.