Skip to content
This repository has been archived by the owner on Feb 24, 2022. It is now read-only.

- Updated and organized the imports; #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

- Updated and organized the imports; #2

wants to merge 2 commits into from

Conversation

tiarebalbi
Copy link

  • Refactored the methods in LocationService;
  • Updated Spring Boot version to 1.2.1.RELEASE;
  • Adjusted some config methods.

- Refactored the methods in LocationService;
- Updated Spring Boot version to 1.2.1.RELEASE;
- Adjusted some config methods.
@thiagogcm
Copy link

Hey Tiarê, I was working in the same changes last night.
I did a few different things that you did though

My locationEventStream method is as follow:

@Bean
    public Broadcaster<Location> locationEventStream(Environment env) {
        return Streams.broadcast(env.get());

    }

on findOne and update methods I used Environment.get() instead of Environment.cachedDispatcher()

and I also changed the ratpack version to 0.9.11

@tiarebalbi
Copy link
Author

@thiagogcm i agree with your observation, the only thing that i'll be checking is about the bean definition, as you can see by the picture bellow i don't have access to the method broadcast() on the class Streams.

i sent a parcial change with your comments.

screen

@tiarebalbi
Copy link
Author

I was checking here and the method broadcast() is not static.
https://github.com/reactor/reactor/blob/master/reactor-core/src/main/java/reactor/rx/Stream.java#L306-L308

I'm not sure that this usage "Broadcaster.create()" is the better way to define this bean, i'm open for more opinion.

@thiagogcm
Copy link

That's weird.. I checked the API and it's static
I'm working with M2 build since I couldn't find the RC1 API
selection_006

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants