Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes RecipeManager #4157

Open
wants to merge 1 commit into
base: api-12
Choose a base branch
from
Open

Fixes RecipeManager #4157

wants to merge 1 commit into from

Conversation

mosemister
Copy link
Member

  • Fixes receiving recipes from the RecipeManager

Original Issue:

Calling the following code would cause a ClassCastException caused by Recipe not being able to be cast to RecipeHolder.

Sponge.server().recipeManager().all();

The issue is that in MC 1.21.1, recipes added a wrapper that holds the recipe and the associated key in RecipeHolder and the internal RecipeManager now outputs those RecipeHolder rather then Recipe.

@mosemister mosemister marked this pull request as ready for review January 3, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mosemister