Allow querying block entity data from archetype #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows creating a
BlockEntityArchetypefrom aBlockSnapshotthat is able to query the underlying block entity data. Gabi has some concerns regarding this how it interacts with mods. With the old API 7 system we had problems with tile entities related to the block operations but is the impact here now as big as it was?This data would be only available when a plugin developer asks for it and the mods do not have access to the
Levelwhich they came from which limits the bad things mods could do. Imo no mod should do anything that has side effects in serialization and we should instead ask them to do something alternative.